[ADD FEATURE] Adds a feed delay option to all sources. #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is an intentional delay on the feed you're getting. Some people might want articles that are at least 3 days old, or something like that. This feature allows that possibility. I might modify this in the future to allow individual delays per source, which I think would be more appropriate.
neue-dev
changed the title
neue-dev
changed the title
|
Merged on my fork, It seems to work 👍 |
|
Would you be interested in porting this feature to the community fork? https://github.com/FluentFlame/fluent-flame-reader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is an (optional) delay on the feeds you're getting (if you look under the app settings, there's a new dropdown that implements this). Some people might want articles that are at least 3 days old, or something like that. My colleagues, in particular, prefer to get their news a week late. This commit allows that possibility and only shows articles of a minimum age for all sources.
I might modify this in the future to allow individual delays per source, which I think would be more appropriate. As for now, I'd like to request feedback on what I should improve in this commit that would allow you to accept it.