Fix courtyard exclusion ordering in panels

Author: yaqwsx

kikit/drc.py

@@ -356,6 +356,12 @@ def deserializeExclusion(exclusionText: str, board: pcbnew.BOARD) -> DrcExclusio
 
 def serializeExclusion(exclusion: DrcExclusion) -> str:
     objIds = [x.m_Uuid.AsString() for x in exclusion.objects]
+    # KiCad checks courtyard overlaps in UUID order. Duplicating footprints
+    # assigns new UUIDs, so preserving the source violation's item order makes
+    # the copied exclusion match only when the new UUIDs happen to have the
+    # same relative order.
+    if exclusion.type == "courtyards_overlap":
+        objIds.sort()
     while len(objIds) < 2:
         objIds.append("00000000-0000-0000-0000-000000000000")
     return "|".join([

test/units/test_drc.py

@@ -0,0 +1,33 @@
+from types import SimpleNamespace
+
+from kikit.drc import DrcExclusion, serializeExclusion
+
+
+def item_with_uuid(uuid_value):
+    return SimpleNamespace(
+        m_Uuid=SimpleNamespace(AsString=lambda: uuid_value)
+    )
+
+
+def test_serializeExclusionSortsCourtyardOverlapItemsByUuid():
+    exclusion = DrcExclusion(
+        "courtyards_overlap",
+        (10, 20),
+        [item_with_uuid("bbbbbbbb"), item_with_uuid("aaaaaaaa")]
+    )
+
+    assert serializeExclusion(exclusion) == (
+        "courtyards_overlap|10|20|aaaaaaaa|bbbbbbbb"
+    )
+
+
+def test_serializeExclusionPreservesItemOrderForOtherViolations():
+    exclusion = DrcExclusion(
+        "clearance",
+        (10, 20),
+        [item_with_uuid("bbbbbbbb"), item_with_uuid("aaaaaaaa")]
+    )
+
+    assert serializeExclusion(exclusion) == (
+        "clearance|10|20|bbbbbbbb|aaaaaaaa"
+    )