fix crash on broken API links

fixes #149

Author: cebe

CHANGELOG.md

@@ -4,6 +4,7 @@ Yii Framework 2 apidoc extension Change Log
 2.1.1 under development
 -----------------------
 
+- Bug #149: Fixed crash on wrongly formatted API links (cebe, santosh-1265)
 - Enh #38: Fixed display of default values given as octal or hex notation (hiqsol)
 - Enh: Display TOC only if there is more than one headline (cebe)
 - Enh: Extracted markdown code highlighting to a trait `MarkdownHighlightTrait` (cebe)

helpers/ApiMarkdownTrait.php

@@ -41,7 +41,7 @@ protected function parseApiLinks($text)
                 }
                 /** @var $type TypeDoc */
                 $type = static::$renderer->apiContext->getType($typeName);
-                if ($type === null) {
+                if ($type === null || $subjectName === '') {
                     static::$renderer->apiContext->errors[] = [
                         'file' => ($context !== null) ? $context->sourceFile : null,
                         'message' => 'broken link to ' . $typeName . '::' . $subjectName . (($context !== null) ? ' in ' . $context->name : ''),

models/TypeDoc.php

@@ -54,14 +54,17 @@ class TypeDoc extends BaseDoc
      */
     public function findSubject($subjectName)
     {
-        if ($subjectName[0] != '$') {
+        if (empty($subjectName)) {
+            return null;
+        }
+        if ($subjectName[0] !== '$') {
             foreach ($this->methods as $name => $method) {
                 if (rtrim($subjectName, '()') == $name) {
                     return $method;
                 }
             }
         }
-        if (!empty($subjectName) && substr_compare($subjectName, '()', -2, 2) === 0) {
+        if (substr_compare($subjectName, '()', -2, 2) === 0) {
             return null;
         }
         if ($this->properties === null) {