Skip to content

Commit 546b9d1

Browse files
yann-eugoneJ-Ben87
andauthored
Add user interface to view executed jobs (#104)
* Add user interface to view executed jobs * Allow symfony/css-selector ^5.0 * Fixed potentially non existing assert method * Fixed missing array structure declaration in ConfigurableTemplating * Fixed code style * Fixed some details on bootstrap4 rendering * Add screenshots of UI * Allow to access child jobs on their own * Pluralize job routing * Add screenshot of warnings * Fixed tests * Screenshots gallery * Screenshots gallery * Move sonata screenshot gallery * Added HTTP method requirements to routes * Fixed typo in Yokai * Fixed breadcrumb building errors * Fixed wrong implementation of TemplatingInterface in documentation * Apply doc typo suggestions from code review Co-authored-by: Benoit Jouhaud <[email protected]> * Add test for not finding child job * Inline NotFoundHttpException * Fixed response statuses priorities --------- Co-authored-by: Yann Eugoné <[email protected]> Co-authored-by: Benoit Jouhaud <[email protected]>
1 parent 06ced2c commit 546b9d1

File tree

73 files changed

+3801
-49
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+3801
-49
lines changed

composer.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"symfony/config": "^5.0|^6.0",
2727
"symfony/console": "^5.0|^6.0",
2828
"symfony/dependency-injection": "^5.0|^6.0",
29+
"symfony/form": "^5.0|^6.0",
2930
"symfony/http-kernel": "^5.0|^6.0",
3031
"symfony/framework-bundle": "^5.0|^6.0",
3132
"symfony/messenger": "^5.0|^6.0",
@@ -39,9 +40,15 @@
3940
"phpspec/prophecy-phpunit": "^2.0",
4041
"phpstan/phpstan": "^1.4",
4142
"phpunit/phpunit": "^9.5",
43+
"sonata-project/admin-bundle": "^4.0",
44+
"symfony/browser-kit": "^5.0|^6.0",
45+
"symfony/css-selector": "^5.0|^6.0",
4246
"symfony/filesystem": "^5.0|^6.0",
4347
"symfony/finder": "^5.0|^6.0",
4448
"symfony/process": "^5.0|^6.0",
49+
"symfony/security-bundle": "^5.0|^6.0",
50+
"symfony/translation": "^5.0|^6.0",
51+
"symfony/twig-bundle": "^5.0|^6.0",
4552
"symplify/easy-coding-standard": "^11.3"
4653
},
4754
"replace": {

phpstan-baseline.neon

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -161,44 +161,9 @@ parameters:
161161
path: src/batch-openspout/src/Writer/FlatFileWriter.php
162162

163163
-
164-
message: "#^Cannot access offset 'connection' on mixed\\.$#"
164+
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeDefinition\\:\\:children\\(\\)\\.$#"
165165
count: 1
166-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
167-
168-
-
169-
message: "#^Cannot access offset 'dir' on mixed\\.$#"
170-
count: 1
171-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
172-
173-
-
174-
message: "#^Cannot access offset 'serializer' on mixed\\.$#"
175-
count: 1
176-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
177-
178-
-
179-
message: "#^Cannot access offset 'table' on mixed\\.$#"
180-
count: 1
181-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
182-
183-
-
184-
message: "#^Parameter \\#1 \\$id of class Symfony\\\\Component\\\\DependencyInjection\\\\Reference constructor expects string, mixed given\\.$#"
185-
count: 1
186-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
187-
188-
-
189-
message: "#^Parameter \\#1 \\$id of method Symfony\\\\Component\\\\DependencyInjection\\\\ContainerBuilder\\:\\:getDefinition\\(\\) expects string, mixed given\\.$#"
190-
count: 1
191-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
192-
193-
-
194-
message: "#^Parameter \\#2 \\$id of method Symfony\\\\Component\\\\DependencyInjection\\\\ContainerBuilder\\:\\:setAlias\\(\\) expects string\\|Symfony\\\\Component\\\\DependencyInjection\\\\Alias, mixed given\\.$#"
195-
count: 1
196-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
197-
198-
-
199-
message: "#^Parameter \\#2 \\.\\.\\.\\$values of function sprintf expects bool\\|float\\|int\\|string\\|null, mixed given\\.$#"
200-
count: 3
201-
path: src/batch-symfony-framework/src/DependencyInjection/YokaiBatchExtension.php
166+
path: src/batch-symfony-framework/src/DependencyInjection/Configuration.php
202167

203168
-
204169
message: "#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\\.$#"

src/batch-symfony-framework/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ composer require yokai/batch-symfony-framework
2525
This package provides:
2626

2727
- [integration](docs/getting-started.md) with Symfony framework
28+
- a [UI](docs/ui.md) with Symfony framework
2829

2930

3031
## Contribution

src/batch-symfony-framework/composer.json

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,21 @@
2525
}
2626
},
2727
"require-dev": {
28+
"sonata-project/admin-bundle": "^4.0",
29+
"symfony/filesystem": "^5.0|^6.0",
30+
"symfony/form": "^5.0|^6.0",
31+
"symfony/security-bundle": "^5.0|^6.0",
32+
"symfony/translation": "^5.0|^6.0",
33+
"symfony/twig-bundle": "^5.0|^6.0",
2834
"phpunit/phpunit": "^9.5"
2935
},
36+
"suggest": {
37+
"sonata-project/admin-bundle": "If you want a SonataAdmin like rendering in the user interface",
38+
"symfony/form": "If you want the JobExecution form filter in the user interface",
39+
"symfony/security-bundle": "If you want to secure the access to JobExecution in the user interface",
40+
"symfony/translation": "Required if you want to enable the user interface",
41+
"symfony/twig-bundle": "Required if you want to enable the user interface"
42+
},
3043
"autoload-dev": {
3144
"psr-4": {
3245
"Yokai\\Batch\\Tests\\Bridge\\Symfony\\Framework\\": "tests/"
44.7 KB
Loading
46.9 KB
Loading
69.5 KB
Loading
40.5 KB
Loading
51.5 KB
Loading
57.8 KB
Loading

0 commit comments

Comments
 (0)