Update codebase to PHP 7.4 (#12)

* Add typed properties

* PHP 7.4 arrow function & static closures

Author: yann-eugone

src/batch-box-spout/src/FlatFileReader.php

@@ -35,27 +35,27 @@ final class FlatFileReader implements
     /**
      * @var string
      */
-    private $type;
+    private string $type;
 
     /**
      * @var array
      */
-    private $options;
+    private array $options;
 
     /**
      * @var string
      */
-    private $headersMode;
+    private string $headersMode;
 
     /**
      * @var array|null
      */
-    private $headers;
+    private ?array $headers;
 
     /**
      * @var string|null
      */
-    private $filePath;
+    private ?string $filePath;
 
     public function __construct(
         string $type,

src/batch-box-spout/src/FlatFileWriter.php

@@ -30,32 +30,32 @@ final class FlatFileWriter implements
     /**
      * @var string
      */
-    private $type;
+    private string $type;
 
     /**
      * @var array|null
      */
-    private $headers;
+    private ?array $headers;
 
     /**
      * @var WriterInterface|null
      */
-    private $writer;
+    private ?WriterInterface $writer = null;
 
     /**
      * @var bool
      */
-    private $headersAdded = false;
+    private bool $headersAdded = false;
 
     /**
      * @var string|null
      */
-    private $filePath;
+    private ?string $filePath;
 
     /**
      * @var array
      */
-    private $options;
+    private array $options;
 
     public function __construct(string $type, array $headers = null, string $filePath = null, array $options = [])
     {

src/batch-doctrine-dbal/src/DoctrineDBALJobExecutionStorage.php

@@ -23,82 +23,82 @@ final class DoctrineDBALJobExecutionStorage implements QueryableJobExecutionStor
     /**
      * @var Connection
      */
-    private $connection;
+    private Connection $connection;
 
     /**
      * @var string
      */
-    private $table = 'yokai_batch_job_execution';
+    private string $table = 'yokai_batch_job_execution';
 
     /**
      * @var string
      */
-    private $idCol = 'id';
+    private string $idCol = 'id';
 
     /**
      * @var string
      */
-    private $jobNameCol = 'job_name';
+    private string $jobNameCol = 'job_name';
 
     /**
      * @var string
      */
-    private $statusCol = 'status';
+    private string $statusCol = 'status';
 
     /**
      * @var string
      */
-    private $parametersCol = 'parameters';
+    private string $parametersCol = 'parameters';
 
     /**
      * @var string
      */
-    private $startTimeCol = 'start_time';
+    private string $startTimeCol = 'start_time';
 
     /**
      * @var string
      */
-    private $endTimeCol = 'end_time';
+    private string $endTimeCol = 'end_time';
 
     /**
      * @var string
      */
-    private $summaryCol = 'summary';
+    private string $summaryCol = 'summary';
 
     /**
      * @var string
      */
-    private $failuresCol = 'failures';
+    private string $failuresCol = 'failures';
 
     /**
      * @var string
      */
-    private $warningsCol = 'warnings';
+    private string $warningsCol = 'warnings';
 
     /**
      * @var string
      */
-    private $childExecutionsCol = 'child_executions';
+    private string $childExecutionsCol = 'child_executions';
 
     /**
      * @var string
      */
-    private $logsCol = 'logs';
+    private string $logsCol = 'logs';
 
     /**
      * @var array
      */
-    private $types;
+    private array $types;
 
     /**
      * @var Schema
      */
-    private $schema;
+    private Schema $schema;
 
     /**
      * @var JobExecutionRowNormalizer|null
      */
-    private $normalizer;
+    private ?JobExecutionRowNormalizer $normalizer = null;
 
     public function __construct(Connection $connection, array $options)
     {
@@ -165,7 +165,7 @@ public function createSchemaSql(): array
         $config = $this->connection->getConfiguration();
         $previousFilter = $config->getSchemaAssetsFilter();
 
-        $config->setSchemaAssetsFilter(function ($asset) use ($previousFilter, $toSchema): bool {
+        $config->setSchemaAssetsFilter(static function ($asset) use ($previousFilter, $toSchema): bool {
             $assetName = $asset instanceof AbstractAsset ? $asset->getName() : $asset;
 
             return $toSchema->hasTable($assetName)

src/batch-doctrine-dbal/src/JobExecutionRowNormalizer.php

@@ -23,62 +23,62 @@ final class JobExecutionRowNormalizer
     /**
      * @var string
      */
-    private $idCol = 'id';
+    private string $idCol;
 
     /**
      * @var string
      */
-    private $jobNameCol = 'job_name';
+    private string $jobNameCol;
 
     /**
      * @var string
      */
-    private $statusCol = 'status';
+    private string $statusCol;
 
     /**
      * @var string
      */
-    private $parametersCol = 'parameters';
+    private string $parametersCol;
 
     /**
      * @var string
      */
-    private $startTimeCol = 'start_time';
+    private string $startTimeCol;
 
     /**
      * @var string
      */
-    private $endTimeCol = 'end_time';
+    private string $endTimeCol;
 
     /**
      * @var string
      */
-    private $summaryCol = 'summary';
+    private string $summaryCol;
 
     /**
      * @var string
      */
-    private $failuresCol = 'failures';
+    private string $failuresCol;
 
     /**
      * @var string
      */
-    private $warningsCol = 'warnings';
+    private string $warningsCol;
 
     /**
      * @var string
      */
-    private $childExecutionsCol = 'child_executions';
+    private string $childExecutionsCol;
 
     /**
      * @var string
      */
-    private $logsCol;
+    private string $logsCol;
 
     /**
      * @var string
      */
-    private $dateFormat;
+    private string $dateFormat;
 
     public function __construct(
         string $idCol,

src/batch-doctrine-dbal/tests/DoctrineDBALJobExecutionStorageTest.php

@@ -35,7 +35,7 @@ class DoctrineDBALJobExecutionStorageTest extends TestCase
     /**
      * @var Connection
      */
-    private $connection;
+    private Connection $connection;
 
     protected function setUp(): void
     {

src/batch-doctrine-orm/src/EntityReader.php

@@ -14,12 +14,12 @@ final class EntityReader implements ItemReaderInterface
     /**
      * @var ManagerRegistry
      */
-    private $doctrine;
+    private ManagerRegistry $doctrine;
 
     /**
      * @var string
      */
-    private $class;
+    private string $class;
 
     public function __construct(ManagerRegistry $doctrine, string $class)
     {

src/batch-doctrine-orm/tests/User.php

@@ -6,7 +6,7 @@
 
 class User
 {
-    public $id;
+    public string $id;
 
     public function __construct(string $id)
     {

src/batch-doctrine-persistence/src/ObjectWriter.php

@@ -14,22 +14,22 @@ final class ObjectWriter implements ItemWriterInterface
     /**
      * @var ManagerRegistry
      */
-    private $doctrine;
+    private ManagerRegistry $doctrine;
 
     /**
      * @var ObjectManager[]
      */
-    private $encounteredManagers = [];
+    private array $encounteredManagers = [];
 
     /**
      * @var ObjectManager[]
      */
-    private $encounteredClasses = [];
+    private array $encounteredClasses = [];
 
     /**
      * @var ObjectManager[]
      */
-    private $managerForClass = [];
+    private array $managerForClass = [];
 
     public function __construct(ManagerRegistry $doctrine)
     {

src/batch-doctrine-persistence/tests/Group.php

@@ -6,7 +6,7 @@
 
 class Group
 {
-    public $id;
+    public string $id;
 
     public function __construct(string $id)
     {

src/batch-doctrine-persistence/tests/Product.php

@@ -6,7 +6,7 @@
 
 class Product
 {
-    public $id;
+    public string $id;
 
     public function __construct(string $id)
     {