Added integration tests as a simple standalone Symfony project (#48)

* Moved tests to Unit namespace

* Added integration tests as a simple standalone Symfony project

* Add link from README to integration test suite

* Do not require symfony/symfony in GitHub actions

* Fixed error in composer.json

Author: yann-eugone

.github/workflows/tests.yml

@@ -35,8 +35,13 @@ jobs:
 
       - name: "Install dependencies with composer"
         run: |
-          composer require --no-update --dev symfony/symfony:${{ matrix.symfony-version }}
-          composer update --no-interaction --no-progress --no-suggest
+          composer require --no-update symfony/framework-bundle:${{ matrix.symfony-version }}
+          composer require --no-update --dev symfony/form:${{ matrix.symfony-version }}
+          composer require --no-update --dev symfony/twig-bundle:${{ matrix.symfony-version }}
+          composer require --no-update --dev symfony/validator:${{ matrix.symfony-version }}
+          composer require --no-update --dev symfony/translation:${{ matrix.symfony-version }}
+          composer require --no-update --dev symfony/yaml:${{ matrix.symfony-version }}
+          composer update --no-interaction --no-progress
 
       - name: "Run tests with phpunit/phpunit"
         run: vendor/bin/phpunit
@@ -61,7 +66,7 @@ jobs:
           php-version: ${{ matrix.php-version }}
 
       - name: "Install dependencies with composer"
-        run: composer update --no-interaction --no-progress --no-suggest
+        run: composer update --no-interaction --no-progress
 
       - name: "Run tests with phpunit/phpunit"
         env:
@@ -92,7 +97,7 @@ jobs:
           php-version: ${{ matrix.php-version }}
 
       - name: "Install dependencies with composer"
-        run: composer update --no-interaction --no-progress --no-suggest
+        run: composer update --no-interaction --no-progress
 
       - name: "Run checkstyle with squizlabs/php_codesniffer"
         run: vendor/bin/phpcs

.gitignore

@@ -1,4 +1,5 @@
 /.idea/
+/tests/Integration/var/
 /vendor/
 /.phpcs-cache
 /.phpunit.result.cache

README.md

@@ -177,7 +177,9 @@ status.disabled: Désactivé
 
 ## More examples
 
-See examples from [test suite](tests/Fixtures) & associated [tests](tests/EnumsFromFixturesTest.php).
+See examples from [unit test suite](tests/Unit/Fixtures) & associated [tests](tests/Unit/EnumsFromFixturesTest.php).
+
+See example Symfony project in [integration test suite](tests/Integration).
 
 
 ## Recipes

composer.json

@@ -20,8 +20,10 @@
         "phpunit/phpunit": "^9.4",
         "squizlabs/php_codesniffer": "^3.5",
         "symfony/form": "^4.4|^5.0",
+        "symfony/translation": "^4.4|^5.0",
         "symfony/twig-bundle": "^4.4|^5.0",
         "symfony/validator": "^4.4|^5.0",
+        "symfony/yaml": "^4.4|^5.0",
         "twig/twig": "^2.0|^3.0"
     },
     "suggest": {
@@ -35,7 +37,11 @@
         "psr-4": { "Yokai\\EnumBundle\\": "src" }
     },
     "autoload-dev": {
-        "psr-4": { "Yokai\\EnumBundle\\Tests\\": "tests" }
+        "psr-4": {
+            "Yokai\\EnumBundle\\Tests\\Unit\\": "tests/Unit",
+            "Yokai\\EnumBundle\\Tests\\Integration\\App\\": "tests/Integration/src",
+            "Yokai\\EnumBundle\\Tests\\Integration\\": "tests/Integration/tests"
+        }
     },
     "minimum-stability": "stable",
     "extra": {

phpcs.xml.dist

@@ -11,7 +11,9 @@
     <rule ref="PSR12"/>
 
     <file>src/</file>
-    <file>tests/</file>
+    <file>tests/Integration/src/</file>
+    <file>tests/Integration/tests/</file>
+    <file>tests/Unit/</file>
 
     <rule ref="Generic.PHP.ForbiddenFunctions">
         <properties>

phpunit.xml.dist

@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
-         backupGlobals="false"
-         backupStaticAttributes="false"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
+         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          colors="true"
          bootstrap="vendor/autoload.php">
+    <php>
+        <server name="KERNEL_CLASS" value="Yokai\EnumBundle\Tests\Integration\App\Kernel"/>
+    </php>
+
     <testsuites>
-        <testsuite name="YokaiEnumBundle Test Suite">
-            <directory>./tests</directory>
+        <testsuite name="Unit">
+            <directory>./tests/Unit</directory>
+        </testsuite>
+        <testsuite name="Integration">
+            <directory>./tests/Integration/tests</directory>
         </testsuite>
     </testsuites>
     <coverage>

src/DependencyInjection/EnumExtension.php

@@ -56,7 +56,7 @@ public function load(array $configs, ContainerBuilder $container): void
         }
         if ($requiresTwig) {
             $container->register('yokai_enum.twig_extension.enum_extension', EnumTwigExtension::class)
-                ->setArgument('$enumRegistry', $registry)
+                ->setArgument('$registry', $registry)
                 ->addTag('twig.extension');
         }
 

tests/Integration/config/packages/framework.yaml

@@ -0,0 +1 @@
+framework: ~

tests/Integration/config/packages/translation.yaml

@@ -0,0 +1,6 @@
+framework:
+    default_locale: en
+    translator:
+        default_path: '%kernel.project_dir%/translations'
+        fallbacks:
+            - en

tests/Integration/config/services.yaml

@@ -0,0 +1,9 @@
+services:
+    _defaults:
+        autowire: true
+        autoconfigure: true
+
+    Yokai\EnumBundle\Tests\Integration\App\:
+        resource: '../src/'
+        exclude:
+            - '../src/Model/'