Merge pull request #1 from ekkinox/enum-provider

Eloquent enum related exception messages

Author: Yann Eugoné

Enum/AbstractTranslatedEnum.php

@@ -32,7 +32,7 @@ abstract class AbstractTranslatedEnum implements EnumInterface
     public function __construct(TranslatorInterface $translator, $transPattern)
     {
         if (false === strpos($transPattern, '%s')) {
-            throw new InvalidTranslatePatternException($transPattern);
+            throw InvalidTranslatePatternException::placeholderRequired($transPattern);
         }
 
         $this->translator = $translator;

Exception/DuplicatedEnumException.php

@@ -7,5 +7,13 @@
  */
 class DuplicatedEnumException extends \BadMethodCallException
 {
-    //todo
+    /**
+     * @param string $name
+     *
+     * @return DuplicatedEnumException
+     */
+    public static function alreadyRegistered($name)
+    {
+        return new self(sprintf('Enum with name "%s" is already registered', $name));
+    }
 }

Exception/InvalidEnumException.php

@@ -7,5 +7,13 @@
  */
 class InvalidEnumException extends \DomainException
 {
-    //todo
+    /**
+     * @param string $name
+     *
+     * @return InvalidEnumException
+     */
+    public static function nonexistent($name)
+    {
+        return new self(sprintf('Nonexistent enum with name "%s" in registry', $name));
+    }
 }

Exception/InvalidTranslatePatternException.php

@@ -7,5 +7,13 @@
  */
 class InvalidTranslatePatternException extends \InvalidArgumentException
 {
-    //todo
+    /**
+     * @param string $transPattern
+     *
+     * @return InvalidTranslatePatternException
+     */
+    public static function placeholderRequired($transPattern)
+    {
+        return new self(sprintf('Translation pattern "%s" must contain %%s placeholder', $transPattern));
+    }
 }

Registry/EnumRegistry.php

@@ -22,7 +22,7 @@ class EnumRegistry implements EnumRegistryInterface
     public function add(EnumInterface $enum)
     {
         if ($this->has($enum->getName())) {
-            throw new DuplicatedEnumException($enum->getName());
+            throw DuplicatedEnumException::alreadyRegistered($enum->getName());
         }
 
         $this->enums[$enum->getName()] = $enum;
@@ -34,7 +34,7 @@ public function add(EnumInterface $enum)
     public function get($name)
     {
         if (!$this->has($name)) {
-            throw new InvalidEnumException($name);
+            throw InvalidEnumException::nonexistent($name);
         }
 
         return $this->enums[$name];