Raise coverage to 100% (#47)

* Covers EnumTypeGuesser when no Enum constraint is on property

* Fixed & covers enum service validator

Author: yann-eugone

src/DependencyInjection/EnumExtension.php

@@ -49,7 +49,10 @@ public function load(array $configs, ContainerBuilder $container): void
         if ($requiresValidator) {
             $container->register('yokai_enum.validator_constraints.enum_validator', EnumValidator::class)
                 ->setArgument('$enumRegistry', $registry)
-                ->addTag('validator.constraint_validator');
+                ->addTag(
+                    'validator.constraint_validator',
+                    ['alias' => 'yokai_enum.validator_constraints.enum_validator']
+                );
         }
         if ($requiresTwig) {
             $container->register('yokai_enum.twig_extension.enum_extension', EnumTwigExtension::class)

src/Validator/Constraints/Enum.php

@@ -32,6 +32,6 @@ public function getDefaultOption(): string
      */
     public function validatedBy(): string
     {
-        return 'enum';
+        return 'yokai_enum.validator_constraints.enum_validator';
     }
 }

tests/Form/Extension/EnumTypeGuesserTest.php

@@ -10,6 +10,7 @@
 use Symfony\Component\Form\Guess\Guess;
 use Symfony\Component\Form\Guess\TypeGuess;
 use Symfony\Component\Form\Test\TypeTestCase;
+use Symfony\Component\Validator\Constraints\Choice;
 use Symfony\Component\Validator\Constraints\Compound;
 use Symfony\Component\Validator\Mapping\ClassMetadata;
 use Symfony\Component\Validator\Mapping\Factory\MetadataFactoryInterface;
@@ -31,6 +32,7 @@ class EnumTypeGuesserTest extends TypeTestCase
 
     private const TEST_PROPERTY_DIRECT = 'direct';
     private const TEST_PROPERTY_COMPOUND = 'compound';
+    private const TEST_PROPERTY_NONE = 'none';
 
     /**
      * @var EnumTypeGuesser
@@ -53,6 +55,7 @@ protected function setUp(): void
         $this->enumRegistry->add(new StateEnum());
 
         $metadata = new ClassMetadata(self::TEST_CLASS);
+        $metadata->addPropertyConstraint(self::TEST_PROPERTY_NONE, new Choice(['choices' => ['new', 'validated']]));
         $metadata->addPropertyConstraint(self::TEST_PROPERTY_DIRECT, new Enum(['enum' => StateEnum::class]));
         if (class_exists(Compound::class)) {
             $metadata->addPropertyConstraint(
@@ -106,6 +109,11 @@ public function testGuessTypeCompound(): void
         self::assertEquals($guess, $this->guesser->guessType(self::TEST_CLASS, self::TEST_PROPERTY_COMPOUND));
     }
 
+    public function testGuessTypeNone(): void
+    {
+        self::assertNull($this->guesser->guessType(self::TEST_CLASS, self::TEST_PROPERTY_NONE));
+    }
+
     public function testGuessRequired(): void
     {
         self::assertNull($this->guesser->guessRequired(self::TEST_CLASS, self::TEST_PROPERTY_DIRECT));
@@ -148,4 +156,5 @@ class EnumTypeGuesserTest_TestClass
 {
     public $direct;
     public $compound;
+    public $none;
 }

tests/Validator/Constraints/EnumValidatorTest.php

@@ -26,6 +26,11 @@ protected function createValidator(): EnumValidator
         return new EnumValidator($registry);
     }
 
+    public function testEnumIsValidatedByService(): void
+    {
+        self::assertSame('yokai_enum.validator_constraints.enum_validator', (new Enum())->validatedBy());
+    }
+
     public function testAcceptOnlyEnum(): void
     {
         $this->expectException(UnexpectedTypeException::class);