Uniformize tests

Author: yann-eugone

tests/ConfigurableEnumTest.php

@@ -4,6 +4,9 @@
 
 use Yokai\EnumBundle\ConfigurableEnum;
 
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
 class ConfigurableEnumTest extends TestCase
 {
     public function testConfigurability(): void

tests/ConstantExtractorTest.php

@@ -6,6 +6,9 @@
 use Yokai\EnumBundle\ConstantExtractor;
 use Yokai\EnumBundle\Exception\CannotExtractConstantsException;
 
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
 class ConstantExtractorTest extends TestCase
 {
     public function getExtractor(): ConstantExtractor

tests/ConstantListEnumTest.php

@@ -6,6 +6,9 @@
 use Yokai\EnumBundle\ConstantListEnum;
 use Yokai\EnumBundle\Tests\Fixtures\Vehicle;
 
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
 class ConstantListEnumTest extends TestCase
 {
     public function getEnum(string $pattern, string $name): ConstantListEnum

tests/ConstantListTranslatedEnumTest.php

@@ -8,6 +8,9 @@
 use Yokai\EnumBundle\ConstantListTranslatedEnum;
 use Yokai\EnumBundle\Tests\Fixtures\Vehicle;
 
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
 class ConstantListTranslatedEnumTest extends TestCase
 {
     /**
@@ -20,11 +23,6 @@ protected function setUp(): void
         $this->translator = $this->prophesize(TranslatorInterface::class);
     }
 
-    protected function tearDown(): void
-    {
-        $this->translator = null;
-    }
-
     public function getEnum(string $pattern, string $name): ConstantListTranslatedEnum
     {
         return new ConstantListTranslatedEnum(

tests/DependencyInjection/CompilerPass/TaggedEnumCollectorCompilerPassTest.php

@@ -2,6 +2,8 @@
 
 namespace Yokai\EnumBundle\Tests\DependencyInjection\CompilerPass;
 
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
 use Yokai\EnumBundle\DependencyInjection\CompilerPass\TaggedEnumCollectorCompilerPass;
 use Yokai\EnumBundle\Tests\TestCase;
@@ -21,31 +23,26 @@ protected function setUp(): void
         $this->compiler = new TaggedEnumCollectorCompilerPass;
     }
 
-    protected function tearDown(): void
-    {
-        unset($this->compiler);
-    }
-
     public function testCollectWhenServiceNotAvailable(): void
     {
-        $compiler = $this->prophesize('Symfony\Component\DependencyInjection\ContainerBuilder');
+        $compiler = $this->prophesize(ContainerBuilder::class);
         $compiler->hasDefinition('enum.registry')->shouldBeCalled()->willReturn(false);
 
         $this->compiler->process($compiler->reveal());
     }
 
     public function testCollectEnums(): void
     {
-        $registry = $this->prophesize('Symfony\Component\DependencyInjection\Definition');
+        $registry = $this->prophesize(Definition::class);
         $registry->addMethodCall('add', [new Reference('enum.gender')])->shouldBeCalled();
         $registry->addMethodCall('add', [new Reference('enum.type')])->shouldBeCalled();
 
-        $compiler = $this->prophesize('Symfony\Component\DependencyInjection\ContainerBuilder');
+        $compiler = $this->prophesize(ContainerBuilder::class);
         $compiler->hasDefinition('enum.registry')->shouldBeCalled()->willReturn(true);
         $compiler->getDefinition('enum.registry')->shouldBeCalled()->willReturn($registry);
         $compiler->findTaggedServiceIds('enum')->shouldBeCalled()->willReturn([
-            'enum.gender' => $this->prophesize('Symfony\Component\DependencyInjection\Definition')->reveal(),
-            'enum.type' => $this->prophesize('Symfony\Component\DependencyInjection\Definition')->reveal(),
+            'enum.gender' => $this->prophesize(Definition::class)->reveal(),
+            'enum.type' => $this->prophesize(Definition::class)->reveal(),
         ]);
 
         $this->compiler->process($compiler->reveal());

tests/EnumRegistryTest.php

@@ -27,11 +27,6 @@ protected function setUp(): void
         $this->registry = new EnumRegistry;
     }
 
-    protected function tearDown(): void
-    {
-        unset($this->registry);
-    }
-
     public function testAddDuplicatedException(): void
     {
         $this->expectException(DuplicatedEnumException::class);

tests/Form/Extension/EnumTypeGuesserTest.php

@@ -57,9 +57,7 @@ protected function setUp(): void
 
         $this->metadata = new ClassMetadata(self::TEST_CLASS);
         $this->metadata->addPropertyConstraint(self::TEST_PROPERTY, new Enum(['enum' => GenderEnum::class]));
-        $this->metadataFactory = $this->prophesize(
-            'Symfony\Component\Validator\Mapping\Factory\MetadataFactoryInterface'
-        );
+        $this->metadataFactory = $this->prophesize(MetadataFactoryInterface::class);
         $this->metadataFactory->getMetadataFor(self::TEST_CLASS)
             ->willReturn($this->metadata);
 

tests/Form/Type/EnumTypeTest.php

@@ -5,6 +5,8 @@
 use Prophecy\PhpUnit\ProphecyTrait;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\Test\TypeTestCase;
+use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
+use Symfony\Component\OptionsResolver\Exception\MissingOptionsException;
 use Yokai\EnumBundle\EnumRegistry;
 use Yokai\EnumBundle\Form\Type\EnumType;
 use Yokai\EnumBundle\Tests\Fixtures\GenderEnum;
@@ -31,13 +33,13 @@ protected function setUp(): void
 
     public function testEnumOptionIsRequired(): void
     {
-        $this->expectException('Symfony\Component\OptionsResolver\Exception\MissingOptionsException');
+        $this->expectException(MissingOptionsException::class);
         $this->createForm();
     }
 
     public function testEnumOptionIsInvalid(): void
     {
-        $this->expectException('Symfony\Component\OptionsResolver\Exception\InvalidOptionsException');
+        $this->expectException(InvalidOptionsException::class);
         $this->createForm('state');
     }
 

tests/TestCase.php

@@ -5,6 +5,9 @@
 use PHPUnit\Framework\TestCase as PHPUnitTestCase;
 use Prophecy\PhpUnit\ProphecyTrait;
 
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
 abstract class TestCase extends PHPUnitTestCase
 {
     use ProphecyTrait;

tests/Twig/Extension/EnumExtensionTest.php

@@ -25,13 +25,6 @@ protected function setUp(): void
         $this->registry = $this->prophesize(EnumRegistry::class);
     }
 
-    protected function tearDown(): void
-    {
-        unset(
-            $this->registry
-        );
-    }
-
     public function testEnumLabel(): void
     {
         $enum = $this->prophesize(EnumInterface::class);