Skip to content

patch for conda #3

@beckermr

Description

@beckermr

Right now the way this code works, it will be pretty hard to build correctly w/ conda. We need to pre-build all .so's in the package and cannot build anything at runtime. Also, the compiler is hardcoded which won't work with conda's build tools.

I'd suggest the following changes

  1. add an option to the setup.py to build the .so's at install.
  2. change the build line in make.py to use the standard env vars for the C compiler (CC) and various flags (CFLAGS). The code can substitute its own values if those env vars are not present.

You may want to use python's wrapped compiler tools to do the building in any case in order to make the package more portable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions