How to dim inactive code block in Rust

[meocoder31099]

As mentioned above, I am looking for ways to dim inactive code blocks due to #[cfg] directives in Rust similar to how VSCode handles it.

Currently, it displays warning underlines as shown in the image below.

[SomeoneToIgnore]

It actually dims it, but all those underlines do not make it obviously visible.
So, the actual question should be "how to remove underlines of inactive Rust code blocks".

We need to do that in the code, something like https://github.com/zed-industries/zed/pull/31450/files#diff-2f5df760eaa9c247daa459cd907f63f8671deb28f42d49b17e0e902729824d13R289-R291 but in rust.rs

r-a already returns diagnostics with "not necessary" property set, but we cannot dim them all, as for unused foo in the let foo = 3; ones will only dim foo, which is not very visible (see #31355 (comment)).

So, we need to get a better heuristics: presumably, we can check whether such diagnostic spans multiple lines and avoid underlining such diagnostics only.

[SomeoneToIgnore]

Or, alternatively, find a way to introduce yet another user setting for such behavior.

[MrSubidubi]

I think the multi-line approach does sound reasonable. I feel that just dimming part of a line has the same contrast issues as the underlines here (which was why I originally reported this, since I was confused as to why just part was dimmed). It becomes barely visible whereas if the whole line is dimmed, it becomes much more apparent something is different for that part of the code.

Alternatively, we could show underlines with inactive fade only if the diagnostics level is higher than a certain level, but I feel this is arbitrarily chosen and probably better solved for each language server individually. I would also be opposed to adding another setting - feels more reasonable to solve this one time for all users per language server rather than requiring each user to search for the right setting to address this behavior.

[meocoder31099]

It actually dims it, but all those underlines do not make it obviously visible.

You're right.

So, the actual question should be "how to remove underlines of inactive Rust code blocks".

I searched and found a rust-analyzer configuration like this:

"lsp": {
    "rust-analyzer": {
      "diagnostics": {
        "disabled": ["inactive-code"]
      }
    }
}

Unfortunately, the underlines are still there.

[w-charlton-virifides]

I think you've forgotten to put it in the initialisation options:

"lsp": {
    "rust-analyzer": {
        "initialization_options": {
            "diagnostics": {
                "disabled": ["inactive-code"]
            }
        }
    }
}

[w-charlton-virifides]

this disables the annoying underlines, but because the diagnostic is disabled, the code is no longer faded out. A worthy trade-off in the short term, but I'd still like to see this issue addressed, perhaps with the multiple line solution discussed above.

[SomeoneToIgnore]

#32082 had improved situation, presumably, could it be enough for all the above?

[meocoder31099]

#32082 had improved situation, presumably, could it be enough for all the above?

I've just updated Zed, and now inactive code blocks are displaying as expected.

Therefore, I'm closing this discussion as resolved.