Unindentified index 1

[chris-kruining]

src/Generator/MethodGenerator.php -> clearBodyIndention (lines 90 to 109)

is trying to parse the following body:

array (size=1)
0 => string ' return $this->getServiceLocator()->get('Core\Page\Service\PageService');' (length=86)

(this is a vardump of the result from the explode on line 96)

this method asumes that all my functions have an enter at the first line, I'd suggest to make this method a tad bit smarter so that it is able to work when you have a oneliner, like I have in my case.

zendframework-zend-code-001.txt

[chris-kruining]

zendframework-zend-code-001.txt

oops, still getting used to php7 :P

[Ocramius]

Requires a failing test case

[chris-kruining]

Sorry. I'm new to the 'official' bug reporting. How does such a failing test case look like? Do I make a unit test that fails? Do I suply an exsisting unit test with my function so that that test fails?

[Ocramius]

Have a look at the tests in https://github.com/zendframework/zend-code/blob/e21f53c1f8a40dd41245eed1f9887f61a675517b/test/Generator/MethodGeneratorTest.php

[chris-kruining]

This is the code wich caused the bug; because all the functions are 1-liners the explode on \n will fail to produce an array with more than one result
zendframework-zend-code-002.txt

I hope this will help :D

[Ocramius]

@chris-kruining could you try sending a patch for the MethodGeneratorTest.php that I linked above?

[chris-kruining]

testClearBodyIndentation.txt

like this? in my testcase it should fail with the current code in de methodgenerator.
(I couldn't manage to make a pull request, git was being an asshole)

[Saeven]

Test checked in
#83

[Ocramius]

@Saeven thanks! Closing this one as duplicate.