Skip to content

ST DTS lint #90611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ST DTS lint #90611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bf9be
boards: st: change order of reg property in partitions
yishai1999 May 26, 2025
a96ae4f
boards: st: moved status property to end the of nodes
yishai1999 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion boards/st/b_l072z_lrwan1/b_l072z_lrwan1.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ arduino_i2c: &i2c1 {};
&spi1_miso_pa6 &spi1_mosi_pa7>;
pinctrl-names = "default";
status = "okay";

Copy link
Contributor

@etienne-lms etienne-lms May 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the specs, I guess we should rather have:

	pinctrl-names = "default";
+	cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;
	status = "okay";
-	cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;

	lora: lora@0 {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exists in a bunch of places. I think it falls into the category of splitting into paragraphs for readabillity. It's nice to have the cs-gpios right before the spi device sub-nodes because they go together logically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I don't understand why you don't want to change this while still change other status properties placement.
(2 other occurrences).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I fix all the inconsistancies?

cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;

lora: lora@0 {
Expand Down Expand Up @@ -148,8 +149,8 @@ arduino_i2c: &i2c1 {};
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&rtc {
Expand Down
9 changes: 3 additions & 6 deletions boards/st/b_l4s5i_iot01a/b_l4s5i_iot01a.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,15 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c2 {
pinctrl-0 = <&i2c2_scl_pb10 &i2c2_sda_pb11>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";

lis3mdl-magn@1e {
compatible = "st,lis3mdl-magn";
Expand Down Expand Up @@ -208,9 +208,9 @@
status = "okay";

pwm2: pwm {
status = "okay";
pinctrl-0 = <&tim2_ch1_pa15>;
pinctrl-names = "default";
status = "okay";
};
};

Expand Down Expand Up @@ -240,10 +240,8 @@ zephyr_udc0: &usbotg_fs {
&octospim_p1_io0_pe12 &octospim_p1_io1_pe13
&octospim_p1_io2_pe14 &octospim_p1_io3_pe15>;
pinctrl-names = "default";

dmas = <&dma1 0 40 STM32_DMA_PERIPH_RX>; /* request 40 for OCTOSPI1 */
dma-names = "tx_rx";

status = "okay";

mx25r6435f: ospi-nor-flash@90000000 {
Expand All @@ -253,7 +251,6 @@ zephyr_udc0: &usbotg_fs {
spi-bus-width = <OSPI_QUAD_MODE>;
data-rate = <OSPI_STR_TRANSFER>;
writeoc="PP_1_4_4";

status = "okay";

partitions {
Expand Down
18 changes: 8 additions & 10 deletions boards/st/disco_l475_iot1/disco_l475_iot1.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@
};

&clk_msi {
status = "okay";
msi-pll-mode;
msi-range = <11>; /* 48MHz USB bus clk */
status = "okay";
};

&pll {
Expand Down Expand Up @@ -136,15 +136,15 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c2 {
pinctrl-0 = <&i2c2_scl_pb10 &i2c2_sda_pb11>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";

lis3mdl-magn@1e {
compatible = "st,lis3mdl-magn";
Expand Down Expand Up @@ -178,8 +178,8 @@
&i2c3 {
pinctrl-0 = <&i2c3_scl_pc0 &i2c3_sda_pc1>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&spi1 {
Expand All @@ -192,10 +192,9 @@
&spi3_miso_pc11 { slew-rate = "very-high-speed"; };

&spi3 {
status = "okay";

pinctrl-0 = <&spi3_sck_pc10 &spi3_miso_pc11 &spi3_mosi_pc12>;
pinctrl-names = "default";
status = "okay";

cs-gpios = <&gpiod 13 GPIO_ACTIVE_LOW>,
<&gpioe 0 GPIO_ACTIVE_LOW>;
Expand Down Expand Up @@ -249,9 +248,9 @@
status = "okay";

pwm2: pwm {
status = "okay";
pinctrl-0 = <&tim2_ch1_pa15>; /* CN1 pin 2 (ARD.D9-PWM) */
pinctrl-names = "default";
status = "okay";
};
};

Expand All @@ -260,9 +259,9 @@
status = "okay";

pwm15: pwm {
status = "okay";
pinctrl-0 = <&tim15_ch1_pb14>; /* LED2 */
pinctrl-names = "default";
status = "okay";
};
};

Expand Down Expand Up @@ -307,9 +306,9 @@ zephyr_udc0: &usbotg_fs {
};

&dac1 {
status = "okay";
pinctrl-0 = <&dac1_out1_pa4>;
pinctrl-names = "default";
status = "okay";
};

&dma1 {
Expand All @@ -323,7 +322,6 @@ zephyr_udc0: &usbotg_fs {
pinctrl-names = "default";
dmas = <&dma1 5 5 0x0000>;
dma-names = "tx_rx";

status = "okay";

mx25r6435f: qspi-nor-flash@90000000 {
Expand Down
4 changes: 2 additions & 2 deletions boards/st/nucleo_f091rc/nucleo_f091rc.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c2 {
Expand Down Expand Up @@ -170,9 +170,9 @@
};

&dac1 {
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
pinctrl-names = "default";
status = "okay";
};

&dma1 {
Expand Down
6 changes: 3 additions & 3 deletions boards/st/nucleo_f103rb/nucleo_f103rb.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_remap1_pb8 &i2c1_sda_remap1_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&spi1 {
Expand All @@ -120,9 +120,9 @@
status = "okay";

pwm1: pwm {
status = "okay";
pinctrl-0 = <&tim1_ch1_pwm_out_pa8>;
pinctrl-names = "default";
status = "okay";
};
};

Expand All @@ -131,9 +131,9 @@
status = "okay";

pwm2: pwm {
status = "okay";
pinctrl-0 = <&tim2_ch2_pwm_in_pa1>;
pinctrl-names = "default";
status = "okay";
};
};

Expand Down
24 changes: 12 additions & 12 deletions boards/st/nucleo_f207zg/nucleo_f207zg.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,15 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c2 {
pinctrl-0 = <&i2c2_scl_pb10 &i2c2_sda_pb11>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&usart3 {
Expand Down Expand Up @@ -184,7 +184,6 @@ zephyr_udc0: &usbotg_fs {
};

&mac {
status = "okay";
pinctrl-0 = <&eth_rxd0_pc4
&eth_rxd1_pc5
&eth_ref_clk_pa1
Expand All @@ -195,12 +194,13 @@ zephyr_udc0: &usbotg_fs {
pinctrl-names = "default";
phy-connection-type = "rmii";
phy-handle = <&phy>;
status = "okay";
};

&mdio {
status = "okay";
pinctrl-0 = <&eth_mdio_pa2 &eth_mdc_pc1>;
pinctrl-names = "default";
status = "okay";

phy: ethernet-phy@0 {
compatible = "ethernet-phy";
Expand Down Expand Up @@ -245,9 +245,9 @@ zephyr_udc0: &usbotg_fs {
};

&dac1 {
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
pinctrl-names = "default";
status = "okay";
};

&backup_sram {
Expand All @@ -258,41 +258,41 @@ zephyr_udc0: &usbotg_fs {
status = "okay";

pwm1: pwm {
status = "okay";
pinctrl-0 = <&tim1_ch1_pe9>;
pinctrl-names = "default";
status = "okay";
};
};

&timers3 {
status = "okay";
st,prescaler = <10000>;
status = "okay";

pwm3: pwm {
status = "okay";
pinctrl-0 = <&tim3_ch3_pb0>;
pinctrl-names = "default";
status = "okay";
};
};

&timers4 {
status = "okay";
st,prescaler = <10000>;
status = "okay";

pwm4: pwm {
status = "okay";
pinctrl-0 = <&tim4_ch2_pb7>;
pinctrl-names = "default";
status = "okay";
};
};

&timers12 {
status = "okay";
st,prescaler = <10000>;
status = "okay";

pwm12: pwm {
status = "okay";
pinctrl-0 = <&tim12_ch1_pb14>;
pinctrl-names = "default";
status = "okay";
};
};
4 changes: 2 additions & 2 deletions boards/st/nucleo_f334r8/nucleo_f334r8.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&spi1 {
Expand All @@ -112,9 +112,9 @@
status = "okay";

pwm1: pwm {
status = "okay";
pinctrl-0 = <&tim1_ch1_pa8>;
pinctrl-names = "default";
status = "okay";
};
};

Expand Down
6 changes: 3 additions & 3 deletions boards/st/nucleo_f401re/nucleo_f401re.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c3 {
pinctrl-0 = <&i2c3_scl_pa8 &i2c3_sda_pc9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&spi1 {
Expand Down Expand Up @@ -168,9 +168,9 @@
status = "okay";

pwm2: pwm {
status = "okay";
pinctrl-0 = <&tim2_ch1_pa5>;
pinctrl-names = "default";
status = "okay";
};
};

Expand Down
6 changes: 3 additions & 3 deletions boards/st/nucleo_f410rb/nucleo_f410rb.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@
&i2c1 {
pinctrl-0 = <&i2c1_scl_pb8 &i2c1_sda_pb9>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&i2c2 {
pinctrl-0 = <&i2c2_scl_pb10 &i2c2_sda_pb3>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
status = "okay";
};

&spi1 {
Expand All @@ -116,9 +116,9 @@
};

&dac1 {
status = "okay";
pinctrl-0 = <&dac_out1_pa5>;
pinctrl-names = "default";
status = "okay";
};

&flash0 {
Expand Down
Loading
Loading