Skip to content

boards: raspberrypi: rpi_pico: Use sysbuild.overlay #90758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

boards: raspberrypi: rpi_pico: Use sysbuild.overlay #90758

wants to merge 1 commit into from

Conversation

@jlbwoods
Copy link
Contributor

@jlbwoods jlbwoods commented May 28, 2025 •
edited
Loading

Use boards/raspberrypi/rpi_pico/sysbuild.overlay for rpi_pcio to build
SysBuild images.

@github-actions github-actions bot added platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) size: XS A PR changing only a single line of code labels May 28, 2025
nordicjm
nordicjm reviewed May 29, 2025
View reviewed changes
soburi
soburi reviewed May 29, 2025
View reviewed changes
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#90758 (comment)

#90758 (comment)

There are no other issues besides this one from me.

I will approve it as soon as it is fixed.

@soburi soburi mentioned this pull request May 29, 2025
Closed
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from ab507c1 to 90d4914 Compare May 29, 2025 15:47
@jlbwoods jlbwoods requested review from nordicjm and soburi May 29, 2025 15:47
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch 3 times, most recently from 7abaf66 to 0fbd0b3 Compare May 29, 2025 16:44
soburi
soburi previously approved these changes May 29, 2025
View reviewed changes
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from 0fbd0b3 to d10c844 Compare May 31, 2025 16:59
@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 2, 2025

What's the next step to get this merged?

@soburi
Copy link
Member

soburi commented Jun 2, 2025

@nordicjm
Can you take a look again please?

@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from d10c844 to 602e7f3 Compare June 4, 2025 00:03
@soburi
Copy link
Member

soburi commented Jun 4, 2025

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 7, 2025

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

@soburi
Copy link
Member

soburi commented Jun 7, 2025 •
edited
Loading

@jlbwoods
I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

Currently, sysbuild is not the default for SoCs other than those that require different images for two CPUs, such as the ESP32 and NRF91.
For passing tests, we only require adding overlay files.
Therefore, I believe this change requires a justification based on the use case.

The sysbuild configuration is meaningful if enabled mcuboot, but the RP2350 does not have a reason to make it the default.
(The default must keep simple.)
Without it, the change only reduces the user's usable storage.

I don't believe it is necessary to apply sysbuild as the default for the RP2350, as is the case with most other SoCs.

@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 7, 2025

@jlbwoods
I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

Currently, sysbuild is not the default for SoCs other than those that require different images for two CPUs, such as the ESP32 and NRF91. For passing tests, we only require adding overlay files. Therefore, I believe this change requires a justification based on the use case.

The sysbuild configuration is meaningful if enabled mcuboot, but the RP2350 does not have a reason to make it the default. (The default must keep simple.) Without it, the change only reduces the user's usable storage.

I don't believe it is necessary to apply sysbuild as the default for the RP2350, as is the case with most other SoCs.

Thank you for the detailed explanation. Everything make sense now!

I will close this PR and leave the default partitions in place.

@jlbwoods jlbwoods closed this Jun 7, 2025
@jlbwoods jlbwoods mentioned this pull request Jun 10, 2025
Closed
@jlbwoods
Copy link
Contributor Author

Reopening the PR to try out raspberrypi/rpi_pico/sysbuild.overlay way:
zephyrproject-rtos/mcuboot#129

@jlbwoods jlbwoods reopened this Jun 18, 2025
@jlbwoods
boards: raspberrypi: rpi_pico: Use sysbuild.overlay
2c0c687 
Use `boards/raspberrypi/rpi_pico/sysbuild.overlay` for rpi_pcio to build
SysBuild images.

Signed-off-by: John Lin <[email protected]>
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from 602e7f3 to 2c0c687 Compare June 18, 2025 04:42
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@jlbwoods jlbwoods changed the title boards: raspberrypi: rpi_pico: Include default partitions boards: raspberrypi: rpi_pico: Use sysbuild.overlay Jun 18, 2025
@jlbwoods
Copy link
Contributor Author

sysbuild.overlay is not yet implemented.

@jlbwoods jlbwoods closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThreeEights ThreeEights ThreeEights approved these changes

@soburi soburi soburi left review comments

@ajf58 ajf58 Awaiting requested review from ajf58

@yonsch yonsch Awaiting requested review from yonsch

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@soburi soburi

Labels

platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) size: XS A PR changing only a single line of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jlbwoods @soburi @nordicjm @ThreeEights