Skip to content

Conversation

tobiwan88
Copy link
Contributor

Allows to configure the alert or therm mode for triggers based on the low/high temperature treshholds

@zephyrbot zephyrbot added area: Sensors Sensors platform: TI SimpleLink Texas Instruments SimpleLink MCU labels Jul 18, 2025
@tobiwan88 tobiwan88 force-pushed the add_tmp116_alert branch 6 times, most recently from 1696531 to eccff57 Compare July 24, 2025 09:35
@tobiwan88 tobiwan88 marked this pull request as draft July 24, 2025 10:25
@tobiwan88 tobiwan88 marked this pull request as ready for review July 24, 2025 10:55
MaureenHelm
MaureenHelm previously approved these changes Jul 24, 2025
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link

@jeppenodgaard jeppenodgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Thanks!

@tobiwan88 tobiwan88 dismissed stale reviews from bjarki-andreasen and MaureenHelm via 1d2ff05 July 28, 2025 17:15
@tobiwan88 tobiwan88 force-pushed the add_tmp116_alert branch 3 times, most recently from e501690 to 778d575 Compare July 28, 2025 17:42
@tobiwan88 tobiwan88 force-pushed the add_tmp116_alert branch 2 times, most recently from a814089 to 4ac97ca Compare July 29, 2025 06:17
Copy link

@jeppenodgaard jeppenodgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. I forgot to ask you to fix the commit message in the review.
add trigger for alert & p, should probably just be add trigger for alert?

Allows to configure the alert or therm mode for triggers
based on the low/high temperature treshholds
Also adding simple PM

Signed-off-by: Tobias Meyer <[email protected]>
Copy link

@tobiwan88
Copy link
Contributor Author

Changes looks good. I forgot to ask you to fix the commit message in the review. add trigger for alert & p, should probably just be add trigger for alert?

should be fixed now

@cfriedt cfriedt merged commit ceadedf into zephyrproject-rtos:main Jul 30, 2025
26 checks passed
@tobiwan88 tobiwan88 deleted the add_tmp116_alert branch July 31, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants