chore: update dockerfile, ports and README instructions

Author: Singlytran

Dockerfile

@@ -8,28 +8,23 @@ ENV NODE_ENV=$MODE
 # Create app dir
 WORKDIR /app
 
-# Copy all project
-COPY . .
-
 # Install concurrently
 RUN npm install -g concurrently
 
-# Setting backend deps
+# Copy backend dependencies
+COPY package*.json ./
 RUN npm install
 
-# Setup frontend deps
+# Copy frontend dependencies
+COPY frontend/package*.json ./frontend/
 RUN cd frontend && npm install
 
-
-RUN if [ "$MODE" = "prod" ]; then \
-    cd frontend && npm run build; \
-  fi
+COPY . .
 
 # Expose frontend (3000) và backend (3004)
 EXPOSE 3000
 EXPOSE 3004
 
-# Start mode
 CMD sh -c 'if [ "$MODE" = "dev" ]; then concurrently "cd frontend && npm start" "npm run start-dev"; else npm run start; fi'
 
 

README.md

@@ -316,7 +316,7 @@ If the port is changed, please make sure the `PORT` environment variable and Doc
 <strong>Run in Production</strong>
 
 ```bash
-docker compose -f docker-compose.prod.yml up --build -d
+docker compose -f docker-compose.prod.yml up --build
 ```
 
 #### Access the app

docker-compose.prod.yml

@@ -6,9 +6,7 @@ services:
       args:
         MODE: prod
     ports:
-      - "3000:${PORT:-3000}"
+      - "${PORT:-3000}:${PORT:-3000}"
     env_file:
       - .env
-    environment:
-      - NODE_ENV=production
     restart: always

docker-compose.yml

@@ -11,7 +11,7 @@ services:
       - /app/node_modules
     ports:
       - "3004:3004"
-      - "5173:5173"
+      - "3000:3000"
     environment:
       - MODE=dev
       - NODE_ENV=DEVELOPMENT

src/app.js

@@ -15,7 +15,7 @@ const initiateServer = async () => {
 
   app.use(morgan("dev"));
 
-  if (process.env.NODE_ENV === "production") {
+  if (process.env.NODE_ENV === "PRODUCTION") {
     app.use(express.static(path.join(__dirname, "../", "frontend", "build")));
 
     app.get("/*", (req, res) => {