refactor: clean up core helpers

Author: zis3c

components/Loader/Loader.tsx

@@ -1,6 +1,23 @@
 import React, { useEffect, useState, useRef } from 'react';
 import * as Styled from './Loader.styles';
 
+const BOOT_SEQUENCE = [
+  '[0.000000] Linux version 6.8.11-amd64',
+  '[0.018392] Command line: BOOT_IMAGE=/boot/vmlinuz root=/dev/sda1 quiet',
+  '[  OK  ] Started Load Kernel Modules.',
+  '[  OK  ] Mounted /home.',
+  '[  OK  ] Started udev Kernel Device Manager.',
+  '[  OK  ] Started Network Manager.',
+  '[  OK  ] Started Accounts Service.',
+  '[  OK  ] Started D-Bus System Message Bus.',
+  '[  OK  ] Started Light Display Manager.',
+  '[  OK  ] Reached target Graphical Interface.',
+  'Starting Kali GNU/Linux...',
+  'Initializing xfce4-session...',
+  'Loading profile: zis3c',
+  'Starting display manager...',
+];
+
 export interface Props {
   isOnScreen: boolean;
   loadingDuration: number;
@@ -19,24 +36,6 @@ const Loader = ({
   const [bootLines, setBootLines] = useState<string[]>([]);
   const bootRef = useRef<HTMLDivElement>(null);
 
-  // eslint-disable-next-line react-hooks/exhaustive-deps
-  const bootSequence = [
-    '[0.000000] Linux version 6.8.11-amd64',
-    '[0.018392] Command line: BOOT_IMAGE=/boot/vmlinuz root=/dev/sda1 quiet',
-    '[  OK  ] Started Load Kernel Modules.',
-    '[  OK  ] Mounted /home.',
-    '[  OK  ] Started udev Kernel Device Manager.',
-    '[  OK  ] Started Network Manager.',
-    '[  OK  ] Started Accounts Service.',
-    '[  OK  ] Started D-Bus System Message Bus.',
-    '[  OK  ] Started Light Display Manager.',
-    '[  OK  ] Reached target Graphical Interface.',
-    'Starting Kali GNU/Linux...',
-    'Initializing xfce4-session...',
-    'Loading profile: zis3c',
-    'Starting display manager...'
-  ];
-
   useEffect(() => {
     if (!isOnScreen) return;
 
@@ -47,10 +46,10 @@ const Loader = ({
     window.addEventListener('keydown', handleSkip);
     window.addEventListener('click', handleSkip);
 
-    const lineDelay = (loadingDuration - 400) / bootSequence.length;
+    const lineDelay = (loadingDuration - 400) / BOOT_SEQUENCE.length;
     const timeouts: NodeJS.Timeout[] = [];
 
-    bootSequence.forEach((line, index) => {
+    BOOT_SEQUENCE.forEach((line, index) => {
       const t = setTimeout(() => {
         setBootLines((prev) => [...prev, line]);
         if (bootRef.current) {
@@ -70,8 +69,7 @@ const Loader = ({
       window.removeEventListener('click', handleSkip);
       timeouts.forEach(clearTimeout);
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [isOnScreen]);
+  }, [isOnScreen, loadingDuration, onBootComplete]);
 
   if (!isOnScreen) return <></>;
 
@@ -83,7 +81,7 @@ const Loader = ({
             const rest = line.slice(8);
             return (
               <Styled.BootLine key={index}>
-                [  <Styled.OkToken>OK</Styled.OkToken>  ]{rest}
+                [ <Styled.OkToken>OK</Styled.OkToken> ]{rest}
               </Styled.BootLine>
             );
           }

frontend-rest-client/rest/news.ts

@@ -17,6 +17,12 @@ export { getLatestNews };
  * @returns {object} - promise with news articles
  */
 const getLatestNews = (): Promise<AxiosResponse<INewsApiResponse>> => {
+  if (!process.env.NEWS_URL_QUERY || !process.env.NEWS_API_KEY) {
+    return Promise.reject(
+      new Error('News API is not configured for this environment')
+    );
+  }
+
   return withRetry(
     () =>
       makeRequest<INewsApiResponse>({

hooks/useHover.ts

@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 
 /**
  * Custom hook to detect whether the mouse is hovering an element.
@@ -10,16 +10,15 @@ import { useEffect, useState } from 'react';
 export default function useHover(ref: React.RefObject<HTMLElement>): boolean {
   const [isHovering, setIsHovering] = useState(false);
 
-  const on = () => setIsHovering(true);
-  const off = () => setIsHovering(false);
+  const on = useCallback(() => setIsHovering(true), []);
+  const off = useCallback(() => setIsHovering(false), []);
 
   useEffect(() => {
-    if (!ref.current) {
+    const node = ref.current;
+    if (!node) {
       return;
     }
 
-    const node = ref.current;
-
     node.addEventListener('mouseenter', on);
     node.addEventListener('mousemove', on);
     node.addEventListener('mouseleave', off);
@@ -29,9 +28,7 @@ export default function useHover(ref: React.RefObject<HTMLElement>): boolean {
       node.removeEventListener('mousemove', on);
       node.removeEventListener('mouseleave', off);
     };
-
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [off, on, ref]);
 
   return isHovering;
 }

pages/api/contact/index.ts

@@ -2,7 +2,10 @@ import { NextApiRequest, NextApiResponse } from 'next';
 import nc from 'next-connect';
 import { sendEmail } from '../../../backend/controllers/contactsController';
 import { onError } from '../../../middleware/onError';
-import { rateLimiter, validateContactBody } from '../../../middleware/rateLimit';
+import {
+  rateLimiter,
+  validateContactBody,
+} from '../../../middleware/rateLimit';
 import { withCorrelationId } from '../../../middleware/requestId';
 import { setSecurityHeaders } from '../../../middleware/securityHeaders';
 import { logger } from '../../../utils/logger';
@@ -27,6 +30,34 @@ const ALLOWED_ORIGINS = [
   'https://me.zis3c.dev',
 ].filter(Boolean);
 
+const parseRequestOrigin = (
+  value: string | string[] | undefined
+): string | null => {
+  if (!value) {
+    return null;
+  }
+
+  const rawValue = Array.isArray(value) ? value[0] : value;
+
+  try {
+    return new URL(rawValue).origin;
+  } catch {
+    return null;
+  }
+};
+
+export const isAllowedContactRequest = (req: NextApiRequest): boolean => {
+  const requestOrigin =
+    parseRequestOrigin(req.headers.origin) ??
+    parseRequestOrigin(req.headers.referer);
+
+  if (!requestOrigin) {
+    return true;
+  }
+
+  return ALLOWED_ORIGINS.includes(requestOrigin);
+};
+
 handler.post(async (req, res) => {
   // Attach correlation ID
   const correlationId = withCorrelationId(req, res);
@@ -35,8 +66,10 @@ handler.post(async (req, res) => {
   setSecurityHeaders(req, res);
 
   // CSRF: reject cross-origin POSTs without valid origin
-  const origin = req.headers.origin;
-  if (origin && !ALLOWED_ORIGINS.includes(origin)) {
+  const origin =
+    parseRequestOrigin(req.headers.origin) ??
+    parseRequestOrigin(req.headers.referer);
+  if (origin && !isAllowedContactRequest(req)) {
     logger.warn('Blocked cross-origin request', { origin, correlationId });
     return res.status(403).json({
       success: false,

store/action-creators/news-action-creators.ts

@@ -14,6 +14,10 @@ import { logger } from '../../utils/logger';
  */
 export const loadLatestNews = () => {
   return async (dispatch: Dispatch<NewsReducerAction>): Promise<void> => {
+    if (!process.env.NEWS_URL_QUERY || !process.env.NEWS_API_KEY) {
+      return;
+    }
+
     dispatch({ type: NewsReducerActionTypes.LOAD_NEWS_ARTICLES });
     try {
       const { data } = await getLatestNews();

utils/apiFeatures.ts

@@ -1,5 +1,10 @@
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-type MongooseQuery = any;
+type QueryLike = {
+  find: (filter: Record<string, unknown>) => QueryLike;
+  sort: (sortBy: string) => QueryLike;
+  select: (fields: string) => QueryLike;
+  skip: (count: number) => QueryLike;
+  limit: (count: number) => QueryLike;
+};
 
 /**
  * APIfeatures class, enhances mongoose query with additional filtering, sorting, limiting and pagination functionality
@@ -12,10 +17,10 @@ export class APIfeatures {
   queryString: {
     [key: string]: string;
   };
-  query: MongooseQuery;
+  query: QueryLike;
 
   constructor(
-    query: MongooseQuery,
+    query: QueryLike,
     queryString: {
       [key: string]: string;
     }