Defining multiple input-processor-temp-layers produces compile warnings/errors

[adamlopresto]

I have a setup with two trackballs, and I'm attempting to set different auto mouse layers on each of them. When I add add them both to my keymap, I get a compilation warning/error (warning that causes the build to fail due to -Wfatal-errors). If I have just one, it works correctly.

Excerpt from keymap (at end of behaviors section)

    zip_auto_mouse: zip_auto_mouse {
        compatible = "zmk,input-processor-temp-layer";
        #input-processor-cells = <2>;
        require-prior-idle-ms = <500>;
        excluded-positions = <37 38 39 40>;
    };

    zip_auto_scroll: zip_auto_scroll {
        compatible = "zmk,input-processor-temp-layer";
        #input-processor-cells = <2>;
        require-prior-idle-ms = <500>;
        excluded-positions = <64>;
    };

Error message from github action:

/tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c: In function 'layer_disable_callback':
/tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c:126:9: warning: unused variable 'ret' [-Wunused-variable]
126 | int ret = k_msgq_put(&temp_layer_action_msgq, &action, K_MSEC(10));
| ^~~
In file included from /tmp/zmk-config/zephyr/include/zephyr/sys/util_macro.h:34,
from /tmp/zmk-config/zephyr/include/zephyr/sys/util.h:17,
from /tmp/zmk-config/zephyr/include/zephyr/sys/atomic.h:18,
from /tmp/zmk-config/zephyr/include/zephyr/kernel_includes.h:25,
from /tmp/zmk-config/zephyr/include/zephyr/kernel.h:17,
from /tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c:9:
/tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c: At top level:
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:45:70: error: missing binary operator before token "1"
45 | #define Z_IS_ENABLED2(one_or_two_args) Z_IS_ENABLED3(one_or_two_args 1, 0)
| ^
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:72:26: note: in definition of macro '__DEBRACKET'
72 | #define __DEBRACKET(...) VA_ARGS
| ^~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:64:9: note: in expansion of macro '__GET_ARG2_DEBRACKET'
64 | __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
| ^~~~~~~~~~~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:59:9: note: in expansion of macro '__COND_CODE'
59 | __COND_CODE(_XXXX##_flag, _if_1_code, _else_code)
| ^~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_macro.h:204:9: note: in expansion of macro 'Z_COND_CODE_1'
204 | Z_COND_CODE_1(_flag, _if_1_code, _else_code)
| ^~~~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/devicetree.h:5004:9: note: in expansion of macro 'COND_CODE_1'
5004 | COND_CODE_1(DT_HAS_COMPAT_STATUS_OKAY(DT_DRV_COMPAT),
| ^~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:45:40: note: in expansion of macro 'Z_IS_ENABLED3'
45 | #define Z_IS_ENABLED2(one_or_two_args) Z_IS_ENABLED3(one_or_two_args 1, 0)
| ^~~~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:28:37: note: in expansion of macro 'Z_IS_ENABLED2'
28 | #define Z_IS_ENABLED1(config_macro) Z_IS_ENABLED2(_XXXX##config_macro)
| ^~~~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_macro.h:148:34: note: in expansion of macro 'Z_IS_ENABLED1'
148 | #define IS_ENABLED(config_macro) Z_IS_ENABLED1(config_macro)
| ^~~~~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/devicetree.h:837:9: note: in expansion of macro 'IS_ENABLED'
837 | IS_ENABLED(DT_CAT6(node_id, P, prop, IDX, idx, _EXISTS))
| ^~~~~~~~~~
/tmp/zmk-config/zephyr/include/zephyr/devicetree.h:4207:9: note: in expansion of macro 'DT_PROP_HAS_IDX'
4207 | DT_PROP_HAS_IDX(DT_DRV_INST(inst), prop, idx)
| ^~~~~~~~~~~~~~~
/tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c:288:41: note: in expansion of macro 'DT_INST_PROP_HAS_IDX'
288 | #define NEEDS_POSITION_HANDLERS(n, ...) DT_INST_PROP_HAS_IDX(n, excluded_positions, 0)
| ^~~~~~~~~~~~~~~~~~~~
/tmp/tmp.cBbLinTFi2/zephyr/include/generated/zephyr/devicetree_generated.h:45856:95: note: in expansion of macro 'NEEDS_POSITION_HANDLERS'
45856 | #define DT_FOREACH_OKAY_INST_VARGS_zmk_input_processor_temp_layer(fn, ...) fn(0, VA_ARGS) fn(1, VA_ARGS)
| ^~
/tmp/zmk-config/zephyr/include/zephyr/sys/util_internal.h:105:36: note: in expansion of macro 'DT_FOREACH_OKAY_INST_VARGS_zmk_input_processor_temp_layer'
105 | #define UTIL_PRIMITIVE_CAT(a, ...) a##VA_ARGS
| ^
/tmp/zmk-config/zmk/app/src/pointing/input_processor_temp_layer.c:296:5: note: in expansion of macro 'DT_INST_FOREACH_STATUS_OKAY_VARGS'
296 | #if DT_INST_FOREACH_STATUS_OKAY_VARGS(NEEDS_POSITION_HANDLERS, ||)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
[31/476] Building C object CMakeFiles/app.dir/src/pointing/input_processor_scaler.c.obj
[32/476] Building C object CMakeFiles/app.dir/src/pointing/input_processor_code_mapper.c.obj
[33/476] Building C object CMakeFiles/app.dir/src/pointing/input_processor_behaviors.c.obj
[34/476] Building C object CMakeFiles/app.dir/src/pointing/input_split.c.obj
[35/476] Building C object CMakeFiles/app.dir/src/hid.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/local/bin/cmake --build /tmp/tmp.cBbLinTFi2
Error: Process completed with exit code 1.

[caksoylar]

Can you test #3241?

[adamlopresto]

That definitely seems like it's aimed at addressing my issue. I don't actually know how to test it (I'm not quite up to working on the main branch; I have my keymap file in a repository and know just enough to be dangerous with it).

[caksoylar]

You can try https://zmk.dev/docs/features/modules#beta-testing but you'd need to migrate your board definitions etc. to main first, yes. You could try cherry-picking the PR commit to v0.3 if you are comfortable with git. If not, I can give it an attempt, let me know.

[adamlopresto]

I'm not really comfortable enough with git, or with ZMK and west etc. Ever so-slowly going beyond just tweaking my keymap and pretending I know what I'm doing.

As far as I can tell, my keyboard is already on main (although that's caused some other issues and the upstream maintainer has talked about pinning it to v0.3, but hasn't yet). Based on the module beta testing guide, it seemed like I should be able to just use a west.yml of

manifest:
  remotes:
    - name: zmkfirmware
      url-base: https://github.com/zmkfirmware
    - name: forkedzmk
      url-base: https://github.com/nobyk
    - name: Cyboard-DigitalTailor
      url-base: https://github.com/Cyboard-DigitalTailor
    - name: ssbb
      url-base: https://github.com/ssbb
    # Additional modules containing boards/shields/custom code can be listed here as well
    # See https://docs.zephyrproject.org/3.2.0/develop/west/manifest.html#projects
  projects:
    - name: zmk
    #      remote: zmkfirmware
    #  revision: main
      remote: forkedzmk
      revision: v0.3-multiple-temp-layers
      import: app/west.yml
    - name: zmk-keyboards
      remote: Cyboard-DigitalTailor
      revision: main
      import: config/west.yml
    - name: zmk-listeners
      remote: ssbb
      revision: v1
  self:
    path: config

But then it's not recognizing my keyboard at all, so clearly something else is going on, like I somehow broke my connection to my board's config:

+ west build -s zmk/app -d /tmp/tmp.niapPEdeBX -b assimilator-bt -- -DZMK_CONFIG=/tmp/zmk-config/config -DSHIELD=imprint_left -DZMK_EXTRA_MODULES=/__w/zmk-user-config-template/zmk-user-config-template
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: /tmp/zmk-config/zmk/app
-- CMake version: 3.31.6
-- Found Python3: /usr/bin/python3 (found suitable version "3.12.3", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /tmp/zmk-config/zephyr/.cache
-- Zephyr version: 3.5.0 (/tmp/zmk-config/zephyr)
-- Found west (found suitable version "1.5.0", minimum required is "0.14.0")
-- Adding /tmp/zmk-config/zmk-keyboards/boards/shields/imprint
-- ZMK Config directory: /tmp/zmk-config/config
-- ZMK Config Kconfig: /tmp/zmk-config/config/imprint.conf
-- Using keymap file: /tmp/zmk-config/config/imprint.keymap
-- Using keymap file: /tmp/zmk-config/config/imprint.keymap
-- Board: assimilator-bt
-- Shield(s): imprint_left
CMake Error at /tmp/zmk-config/zephyr/cmake/modules/arch.cmake:45 (message):
  Could not find ARCH=cyboard for BOARD=assimilator-bt, please check your
  installation.  ARCH roots searched:

  /tmp/zmk-config/zephyr
Call Stack (most recent call first):
  /tmp/zmk-config/zephyr/cmake/modules/zephyr_default.cmake:129 (include)
  /tmp/zmk-config/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  /tmp/zmk-config/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:9 (find_package)


-- Configuring incomplete, errors occurred!
FATAL ERROR: command exited with status 1: /usr/local/bin/cmake -DWEST_PYTHON=/usr/bin/python3 -B/tmp/tmp.niapPEdeBX -GNinja -DBOARD=assimilator-bt -DZMK_CONFIG=/tmp/zmk-config/config -DSHIELD=imprint_left -DZMK_EXTRA_MODULES=/__w/zmk-user-config-template/zmk-user-config-template -S/tmp/zmk-config/zmk/app
Error: Process completed with exit code 1.

If that PR is likely to get approved any time soon, I may just wait. Testing it would be nice, but I don't know how much more time is worth trying to resolve this one thing if I'll eventually want to roll back to baseline.

[caksoylar]

Sorry, I hadn't checked the branch but it looks like it is based on v0.3, not main. I rebased it on main and pushed it to https://github.com/caksoylar/zmk/tree/main-multiple-temp-layers, if you have time for another attempt.