Skip to content

Conversation

@bhatia4404
Copy link
Collaborator

Issue : #1087
Zulip Desktop App Version : 5.12.0
Fixes:
Fixed the space between "Add Organization" Button and its tooltip.
Spacing is same as other buttons like settings, reload, dnd and back.

Screenshots and screen captures:

Before
image

image

After
image

image

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (specify distro)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@shubham-padia
Copy link
Member

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

@shubham-padia
Copy link
Member

Thank you for your contribution, we have had PRs open for #1087 before this was opened. Please check for open PRs on an issue before attempting to solve it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants