model/views: Acknowledge case sensitive topics in topic list update.

Also, amended related _update_topic_index().

Author: preetmishra

zulipterminal/model.py

@@ -410,6 +410,11 @@ def _fetch_topics_in_streams(self, stream_list: Iterable[int]) -> str:
         for stream_id in stream_list:
             response = self.client.get_stream_topics(stream_id)
             if response['result'] == 'success':
+                # NOTE: The server only sends the latest topic name version for
+                # case sensitive topic names.
+                # See (https://github.com/zulip/zulip/blob
+                # /2e5f860d41bb441597f7f088a477d5946cab4b13/zerver/lib
+                # /topic.py#L144).
                 self.index['topics'][stream_id] = [topic['name'] for
                                                    topic in response['topics']]
             else:
@@ -931,8 +936,10 @@ def _update_topic_index(self, stream_id: int, topic_name: str) -> None:
         """
         topic_list = self.topics_in_stream(stream_id)
         for topic_iterator, topic in enumerate(topic_list):
-            if topic == topic_name:
-                topic_list.insert(0, topic_list.pop(topic_iterator))
+            if compare_lowercase(topic, topic_name):
+                topic_list.pop(topic_iterator)
+                # Use the latest topic name version to update.
+                topic_list.insert(0, topic_name)
                 break
         else:
             # No previous topics with same topic names are found

zulipterminal/ui_tools/views.py

@@ -12,7 +12,8 @@
     CHECK_MARK, LIST_TITLE_BAR_LINE, PINNED_STREAMS_DIVIDER,
 )
 from zulipterminal.helper import (
-    Message, asynch, canonicalize_topic, match_stream, match_user,
+    Message, asynch, canonicalize_topic, compare_lowercase, match_stream,
+    match_user,
 )
 from zulipterminal.ui_tools.boxes import PanelSearchBox
 from zulipterminal.ui_tools.buttons import (
@@ -392,8 +393,20 @@ def update_topics_list(self, stream_id: int, topic_name: str,
         # More recent topics are found towards the beginning
         # of the list.
         for topic_iterator, topic_button in enumerate(self.log):
-            if topic_button.topic_name == topic_name:
-                self.log.insert(0, self.log.pop(topic_iterator))
+            if compare_lowercase(topic_button.topic_name, topic_name):
+                updated_topic_button = self.log.pop(topic_iterator)
+                # Use the latest topic name version to update the topic list if
+                # it has been updated.
+                if topic_button.topic_name != topic_name:
+                    updated_topic_button = TopicButton(
+                        stream_id=stream_id,
+                        topic=topic_name,
+                        controller=self.view.controller,
+                        width=self.view.LEFT_WIDTH,
+                        count=self.view.model.unread_counts['unread_topics'].
+                        get((stream_id, canonicalize_topic(topic_name)), 0),
+                    )
+                self.log.insert(0, updated_topic_button)
                 self.list_box.set_focus_valign('bottom')
                 if sender_id == self.view.model.user_id:
                     self.list_box.set_focus(0)