model/views: Handle Invalid File Location and other possible errors.

If a passed file location is invalid then the get_file_upload_uri
returns None and using that the error and reported.

Author: Subhasish-Behera

zulipterminal/model.py

@@ -4,6 +4,7 @@
 
 import itertools
 import json
+import os
 import time
 from collections import defaultdict
 from concurrent.futures import Future, ThreadPoolExecutor, wait
@@ -557,10 +558,16 @@ def send_stream_message(self, stream: str, topic: str, content: str) -> bool:
             notify_if_message_sent_outside_narrow(composition, self.controller)
         return message_was_sent
 
-    def get_file_upload_uri(self, file_location: str) -> str:
-        with open(file_location, "rb") as fp:
-            result = self.client.upload_file(fp)
-        return result["uri"]
+    def get_file_upload_uri(self, file_location: str) -> Optional[str]:
+        if os.path.exists(file_location):
+            with open(file_location, "rb") as fp:
+                result = self.client.upload_file(fp)
+                if result["result"] == "success":
+                    return result["uri"]
+                else:
+                    return None
+        else:
+            return None
 
     def update_private_message(self, msg_id: int, content: str) -> bool:
         request: PrivateMessageUpdateRequest = {

zulipterminal/ui_tools/views.py

@@ -1194,9 +1194,13 @@ def __init__(
 
     def _handle_file_upload(self, file_location: str) -> None:
         self.uri = self.model.get_file_upload_uri(file_location)
-        file_path = Path(file_location)
-        file_name = file_path.name
-        self.write_box.append_uri_and_filename(file_name, self.uri)
+        if self.uri is not None:
+            file_path = Path(file_location)
+            file_name = file_path.name
+            self.write_box.append_uri_and_filename(file_name, self.uri)
+        else:
+            self.controller.report_error(["ERROR: Unable to get the URI"])
+        self.controller.exit_popup()
 
     def keypress(self, size: urwid_Size, key: str) -> str:
         if is_command_key("ENTER", key):