tests: helper: Test set_count for group pms.

Add test for verifying unread_counts when marking group pms as
read/unread.

Add group pm message entries to index fixture.

Author: kaustubh-nair

tests/conftest.py

@@ -808,7 +808,26 @@ def index_multiple_messages():
              'display_recipient': [{'id': 202}]},
         16: {'id': 16, 'type': 'private', 'sender_id': 200,
              'display_recipient': [{'id': 202}, {'id': 200}]},
+        # group-pms
+        17: {'id': 17, 'type': 'private', 'sender_id': 202,
+             'display_recipient': [{'id': 202}, {'id': 201}, {'id': 200}]},
+        18: {'id': 18, 'type': 'private', 'sender_id': 200,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 201}]},
+        19: {'id': 19, 'type': 'private', 'sender_id': 201,
+             'display_recipient': [{'id': 202}, {'id': 201}, {'id': 200}]},
+        20: {'id': 21, 'type': 'private', 'sender_id': 200,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 201}]},
+        21: {'id': 20, 'type': 'private', 'sender_id': 202,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 199}]},
+        22: {'id': 20, 'type': 'private', 'sender_id': 202,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 199}]},
+        23: {'id': 20, 'type': 'private', 'sender_id': 202,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 199}]},
+        24: {'id': 20, 'type': 'private', 'sender_id': 202,
+             'display_recipient': [{'id': 202}, {'id': 200}, {'id': 199},
+                                   {'id': 198}]},
         }})
+
 # --------------- UI Fixtures -----------------------------------------
 
 

tests/helper/test_helper.py

@@ -79,6 +79,43 @@ def test_set_count_pms(mocker, initial_unread_counts, all_msg,
     assert controller.model.unread_counts == expected_unread_counts
 
 
+@pytest.mark.parametrize('all_msg, all_pms, unread_huddles', [
+    (4, 3, {frozenset({202, 200, 201}): 2, frozenset({202, 200, 199, 198}): 1})
+    ])
+@pytest.mark.parametrize(('new_count, id_list, expected_all_msg,'
+                         'expected_all_pms, expected_unread_huddles'), [
+    (-1, [20, 18], 2, 1, {frozenset({202, 200, 199, 198}): 1}),
+    (-1, [20, 18, 24], 1, 0, {}),
+    (-1, [], 4, 3, {frozenset({202, 200, 201}): 2,
+                    frozenset({202, 200, 199, 198}): 1}),
+    (1, [17, 19], 6, 5, {frozenset({202, 200, 201}): 4,
+                         frozenset({202, 200, 199, 198}): 1}),
+    (1, [17, 19, 23], 7, 6, {frozenset({202, 200, 201}): 4,
+                             frozenset({202, 200, 199, 198}): 1,
+                             frozenset({202, 200, 199}): 1}),
+    (1, [], 4, 3, {frozenset({202, 200, 201}): 2,
+                   frozenset({202, 200, 199, 198}): 1}),
+    ])
+def test_set_count_group_pms(mocker, initial_unread_counts, all_msg, new_count,
+                             all_pms, unread_huddles, user_id, id_list,
+                             expected_unread_huddles, expected_all_pms,
+                             expected_all_msg, index_multiple_messages):
+    controller = mocker.patch('zulipterminal.core.Controller.__init__')
+    controller.model.index = index_multiple_messages
+
+    unread_counts = deepcopy(dict(initial_unread_counts,
+                                  **{'all_msg': all_msg, 'all_pms': all_pms,
+                                     'unread_huddles': unread_huddles}))
+    expected_unread_counts = dict(initial_unread_counts,
+                                  **{'all_msg': expected_all_msg,
+                                     'all_pms': expected_all_pms,
+                                     'unread_huddles': expected_unread_huddles
+                                     })
+    controller.model.unread_counts = unread_counts
+    set_count(id_list, controller, new_count)
+    assert controller.model.unread_counts == expected_unread_counts
+
+
 def test_index_messages_narrow_all_messages(mocker,
                                             messages_successful_response,
                                             index_all_messages,