Skip to content

Commit 914fc53

Browse files
preetmishraneiljp
authored andcommitted
tests: ui: Migrate simple keypress tests to use keys_for_command.
The previous keypress tests used hardcoded tests against specific keys. This could have potentially broken tests if any keybinding would have updated. Updated trivial keypress tests to use `keys_for_command` to ensure that the tests are future-proof and they work for multiple specified keys.
1 parent badf47a commit 914fc53

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/ui/test_ui.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,15 @@ def test_keypress_normal_mode_navigation(self, view, mocker,
205205
view.keypress(size, key)
206206
super_view.assert_called_once_with(size, expected_key)
207207

208-
def test_keypress_ALL_MENTIONS(self, view, mocker):
208+
@pytest.mark.parametrize('key', keys_for_command('ALL_MENTIONS'))
209+
def test_keypress_ALL_MENTIONS(self, view, mocker, key):
209210
view.body = mocker.Mock()
210211
view.body.focus_col = None
211212
view.controller.editor_mode = False
212213
size = (20,)
213214
view.model.controller.show_all_mentions = mocker.Mock()
214215

215-
view.keypress(size, "#")
216+
view.keypress(size, key)
216217
view.model.controller.show_all_mentions.assert_called_once_with(view)
217218
assert view.body.focus_col == 1
218219

@@ -270,7 +271,8 @@ def test_keypress_q(self, view, mocker, autohide):
270271
assert view.controller.editor_mode is True
271272
assert view.controller.editor == view.stream_w.stream_search_box
272273

273-
def test_keypress_edit_mode(self, view, mocker):
274+
@pytest.mark.parametrize('key', keys_for_command('SEARCH_PEOPLE'))
275+
def test_keypress_edit_mode(self, view, mocker, key):
274276
view.users_view = mocker.Mock()
275277
view.body = mocker.Mock()
276278
view.user_search = mocker.Mock()
@@ -281,5 +283,5 @@ def test_keypress_edit_mode(self, view, mocker):
281283
# Test Edit Mode Keypress
282284
view.controller.editor_mode = True
283285
size = (130, 28)
284-
view.keypress(size, "w")
285-
view.controller.editor.keypress.assert_called_once_with((28,), "w")
286+
view.keypress(size, key)
287+
view.controller.editor.keypress.assert_called_once_with((28,), key)

0 commit comments

Comments
 (0)