Skip to content

Commit 9c54b8e

Browse files
Subhasish-Beheraneiljp
authored andcommitted
test_messages: Add and modify test for message labels.
Tests the conditions for moved and edited label along wth UI differences. Fixes #1253
1 parent 1a940dc commit 9c54b8e

File tree

1 file changed

+39
-5
lines changed

1 file changed

+39
-5
lines changed

tests/ui_tools/test_messages.py

Lines changed: 39 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,18 +1135,52 @@ def test_main_view_compact_output(
11351135
assert len(view_components) == 1
11361136
assert isinstance(view_components[0], Padding)
11371137

1138-
def test_main_view_generates_EDITED_label(
1139-
self, mocker, messages_successful_response
1138+
@pytest.mark.parametrize(
1139+
[
1140+
"message_edited",
1141+
"message_moved",
1142+
"expected_left_padding",
1143+
"expected_label_text",
1144+
],
1145+
[
1146+
case(True, False, 7, "EDITED", id="message_indexed_to_edited_messages"),
1147+
case(False, True, 6, "MOVED", id="message_indexed_to_moved_messages"),
1148+
case(
1149+
False,
1150+
False,
1151+
0,
1152+
"EDITED",
1153+
id="message_neither_index_to_edited_messages_or_moved_messages",
1154+
),
1155+
],
1156+
)
1157+
def test_main_view_generates_EDITED_or_MOVED_label(
1158+
self,
1159+
mocker,
1160+
messages_successful_response,
1161+
message_edited,
1162+
message_moved,
1163+
expected_left_padding,
1164+
expected_label_text,
11401165
):
11411166
messages = messages_successful_response["messages"]
11421167
for message in messages:
1143-
self.model.index["edited_messages"].add(message["id"])
1168+
msg_id = message["id"]
1169+
message_index = {
1170+
"edited_messages": {msg_id} if message_edited else set(),
1171+
"moved_messages": {msg_id} if message_moved else set(),
1172+
}
1173+
self.model.index = dict(
1174+
self.model.index,
1175+
edited_messages=message_index["edited_messages"],
1176+
moved_messages=message_index["moved_messages"],
1177+
)
11441178
msg_box = MessageBox(message, self.model, message)
11451179
view_components = msg_box.main_view()
11461180

11471181
label = view_components[0].original_widget.contents[0]
1148-
assert label[0].text == "EDITED"
1149-
assert label[1][1] == 7
1182+
assert label[0].text == expected_label_text
1183+
assert label[1][1] == expected_left_padding
11501184

11511185
@pytest.mark.parametrize(
11521186
"to_vary_in_last_message, update_required",

0 commit comments

Comments
 (0)