Some image (links) don't get rendered

[neiljp]

This occurs since we avoid rendering message_inline_image divs in soup2markup since this was showing duplicate links. However, while in some cases the link is shown anyhow (with the div elided), in others we see no image.

@aero31aero @preetmishra We discussed this previously?

This may be cleaner to fix as a follow-up to #703?

[mkp6781]

I have not exactly understood what the issue is here. Could you elaborate @neiljp .

[Ezio-Sarthak]

@mkp6781 to clarify, take a look at the 1st, 3rd, and 6th message in the screenshot below. (These are some examples of the unwanted link behavior discussed above).

The expected behavior is to add those links too as footlinks. We currently ignore the rendering of such classes of links by adding them to unrendered_div_classes.

Hope this clarifies the issue :)

[neiljp]

This is a blocker for showing the links generated by the new giphy feature, as discussed at https://chat.zulip.org/#narrow/stream/101-design/topic/giphy.20integration/

[neiljp]

I believe this may be connected to #1103