Skip to content

Show detected platform on startup and in About popup #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Show detected platform on startup and in About popup #1221

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1db4d4
run: Add platform information on startup.
plugyawn May 8, 2022
e405fbd
views: Add platform information to the About Pop-Up.
plugyawn May 8, 2022
9857ec0
test: Add tests for detected platform.
plugyawn May 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion zulipterminal/ui_tools/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
match_stream,
match_user,
)
from zulipterminal.platform_code import PLATFORM
from zulipterminal.server_url import near_message_url
from zulipterminal.ui_tools.boxes import MessageBox, PanelSearchBox
from zulipterminal.ui_tools.buttons import (
Expand Down Expand Up @@ -1113,7 +1114,13 @@ def __init__(
else []
)
contents = [
("Application", [("Zulip Terminal", zt_version)]),
(
"Application",
[
("Zulip Terminal", zt_version),
("Platform detected", PLATFORM if PLATFORM else "Invalid platform"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition shouldn't arise - again, check the values of PLATFORM.

],
),
("Server", [("Version", server_version)] + self.feature_level_content),
(
"Application Configuration",
Expand Down