Update accent color always - #5
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the WASDK tray icon flyout backdrop update logic so the backdrop is refreshed more reliably with Windows taskbar appearance settings—especially when taskbar color prevalence is enabled (accent color can change).
Changes:
- Removes color-prevalence state tracking and simplifies the “should update” decision.
- Forces backdrop controller recreation when taskbar color prevalence is enabled (to reflect possible accent color changes).
- Restructures controller selection to primarily track taskbar light/dark changes, with an explicit
coercepath.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can you resolve the merge conflicts? |
Re-indented the code block that selects the appropriate ISystemBackdropControllerWithTargets based on taskbar appearance and user settings. No logic changes were made; this update improves code structure and consistency.
Hi, I resolved the changes already. But the building issues in CI are quite strange. Could you please do me a favor? |
|
Thank you! |
0x5bfa
changed the title
Looks like MSIX packager is acting up. Looking into. |
|
I meant this one, sorry. I'll resolve conflicts on my end, pleae open a new PR for this branch. |
I've fixed this issue in the main branch. |
This pull request refactors the logic for updating the tray icon flyout's backdrop to improve how it responds to changes in taskbar color settings. The update simplifies state tracking and ensures the backdrop updates more reliably when system appearance settings change.
Backdrop update logic improvements:
_wasTaskbarColorPrevalenceLastTimeCheckedfield and its associated state tracking, simplifying the code and reducing unnecessary checks.UpdateBackdropManagerso that the backdrop is now always updated when the taskbar's color prevalence is enabled, ensuring accent color changes are reflected immediately. [1] [2]coerce) and color prevalence cases more clearly. [1] [2]