Force update backdrop when color prevalence is on, as the accent color might change#5
Open
Jack251970 wants to merge 1 commit into0x5bfa:mainfrom
Open
Force update backdrop when color prevalence is on, as the accent color might change#5Jack251970 wants to merge 1 commit into0x5bfa:mainfrom
Jack251970 wants to merge 1 commit into0x5bfa:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the WASDK tray icon flyout backdrop update logic so the backdrop is refreshed more reliably with Windows taskbar appearance settings—especially when taskbar color prevalence is enabled (accent color can change).
Changes:
- Removes color-prevalence state tracking and simplifies the “should update” decision.
- Forces backdrop controller recreation when taskbar color prevalence is enabled (to reflect possible accent color changes).
- Restructures controller selection to primarily track taskbar light/dark changes, with an explicit
coercepath.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for updating the tray icon flyout's backdrop to improve how it responds to changes in taskbar color settings. The update simplifies state tracking and ensures the backdrop updates more reliably when system appearance settings change.
Backdrop update logic improvements:
_wasTaskbarColorPrevalenceLastTimeCheckedfield and its associated state tracking, simplifying the code and reducing unnecessary checks.UpdateBackdropManagerso that the backdrop is now always updated when the taskbar's color prevalence is enabled, ensuring accent color changes are reflected immediately. [1] [2]coerce) and color prevalence cases more clearly. [1] [2]