Skip to content

Add a variation of the Safe{Wallet} Guard timelock for Safe{Wallet} version 1.4.1 - #399

Merged
duncancmt merged 11 commits into
masterfrom
dcmt/upgrade-timelock-1.4.0
Jun 10, 2026
Merged

Add a variation of the Safe{Wallet} Guard timelock for Safe{Wallet} version 1.4.1#399
duncancmt merged 11 commits into
masterfrom
dcmt/upgrade-timelock-1.4.0

Conversation

@duncancmt

Copy link
Copy Markdown
Collaborator

No description provided.

@immunefi-magnus

immunefi-magnus Bot commented Sep 23, 2025

Copy link
Copy Markdown

🛡️ Immunefi PR Reviews

We’ve assigned 5 code reviewer(s) to this PR.

They’ll begin the review shortly and leave feedback directly in the pull request.

This review is based on the current state of your pull request. If you make changes after the review starts, they won’t be reflected here. To ensure the review includes your latest updates, you’ll need to open a new pull request.

@immunefi-magnus immunefi-magnus Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed updated code to be compatible with Safe 1.4. Looks good to me, did not find any major issues.
Left a few nice-to-have type comments

  • OxStrausses

Comment thread src/deployer/SafeGuard.sol
pragma solidity =0.8.25;

// This enum is derived from the code deployed to 0xfb1bffC9d739B8D520DaF37dF666da4C687191EA
import {IERC165} from "@forge-std/interfaces/IERC165.sol";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For contract that are going to be deployed better to import from OpenZeppelin.

  • OxStrausses

Base automatically changed from dcmt/upgrade-timelock to master June 10, 2026 11:07
@duncancmt
duncancmt merged commit 4684b0a into master Jun 10, 2026
2 checks passed
@duncancmt
duncancmt deleted the dcmt/upgrade-timelock-1.4.0 branch June 10, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant