Skip to content

Bug! fix revertTooMuchSlippage token in Velodrome - #536

Merged
jparklev merged 1 commit into
masterfrom
jparklev/fix-velo-slippage-revert
Mar 25, 2026
Merged

Bug! fix revertTooMuchSlippage token in Velodrome#536
jparklev merged 1 commit into
masterfrom
jparklev/fix-velo-slippage-revert

Conversation

@jparklev

@jparklev jparklev commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

re: #528 (comment)

The first arg for revertTooMuchSlippage should be the buy token

function revertTooMuchSlippage(IERC20 buyToken, uint256 expectedBuyAmount, uint256 actualBuyAmount) pure {

Notes:

  • Used the Bug! commit style since I noticed it elsewhere
  • Let me know if you'd like me to add some sort of test on top of this PR

@immunefi-magnus

Copy link
Copy Markdown

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@jparklev
jparklev requested a review from duncancmt March 23, 2026 15:31
@duncancmt

Copy link
Copy Markdown
Collaborator

This is gonna get weird when #529 or #534 go in. Do you mind if I hold off on reviewing this until we reach a decision on those PRs?

@jparklev

jparklev commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

This is gonna get weird when #529 or #534 go in. Do you mind if I hold off on reviewing this until we reach a decision on those PRs?

Yes, sgtm 👍

@jparklev
jparklev merged commit 4e96346 into master Mar 25, 2026
6 checks passed
@jparklev
jparklev deleted the jparklev/fix-velo-slippage-revert branch March 25, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants