feat: Allow signing git commits; fix: Delete exact path instead of parent when source is missing#197
Merged
VojtechVitek merged 6 commits intomasterfrom Mar 30, 2026
Merged
Conversation
When a listed path doesn't exist in the source, the else branch used dirname to compute the deletion target, which deleted the entire parent directory. For example, 'api/client/' missing caused 'api/' to be nuked. Now deletes only the exact path in the destination, or skips with a log message if it doesn't exist there either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git-commit, when a listed path doesn't exist in the source repo, theelsebranch useddirnameto compute the deletion target — deleting the entire parent directory instead of just the missing pathapi/client/missing causedrm -rfonapi/, nuking all sibling directoriesTest plan