feat: ini v3 core #210
Open
feat: ini v3 core #210
+26,432
−1,154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attente
force-pushed
the
v3-core
branch
2 times, most recently
from
86d26f3 to
56c6f8a
Compare
This reverts commit 079c479.
- Removed unnecessary parameters from GetIntentConfigurationSignature, streamlining its functionality. - Cleaned up related test cases in intent_config_test.go to reflect the updated method signature. - Eliminated unused types and functions related to TrailsExecutionInfo, enhancing code clarity and maintainability.
…ionSignature for improved clarity
…configuration (#275) - Updated Factory, MainModule, MainModuleUpgradable, and Guest addresses in `network.go`. - Modified expected address in `TestIntentConfigurationAddress_RealWorldExample` in `intent_config_test.go`. - Adjusted expected wallet address and signature in `TestWalletSignMessageAndValidate` in `wallet_test.go`. - Updated contract artifacts for wallet contracts in JSON files.
…ests by removing unnecessary common.Address parameter
- Updated Factory, MainModule, MainModuleUpgradable, and Guest addresses in `network.go`. - Modified the creation code for V3 in `contracts/contracts.go` to reflect recent changes.
- Updated bytecode and deployed bytecode for various contracts including Estimator, Factory, Guest, Simulator, Stage1Module, Stage2Module, Wallet, and Passkeys. - Added new interfaces for IERC223Receiver, IERC721Receiver, and IERC1155Receiver. - Modified existing contracts to reflect changes in bytecode and structure. - Ensured consistency across all contract artifacts in the wallet-contracts-v3 directory.
- Updated Factory, MainModule, MainModuleUpgradable, Guest, and Utils addresses in `helpers.go` to reflect the latest deployment changes. - Ensured consistency with the recent updates in contract artifacts for V3.
- Introduced a new method `Approval` in the ImageHash struct to generate a digest that must be signed for subsequent ImageHash approvals. - Utilized a predefined salt for the hashing process to ensure consistency and security in the approval mechanism.
VojtechVitek
reviewed
Aug 7, 2025
| if err != nil { | ||
| return common.Address{}, fmt.Errorf("sequence, AddressFromImageHash: %w", err) | ||
| return common.Address{}, fmt.Errorf(`invalid creation code "%v": %w`, context.CreationCode, err) |
There was a problem hiding this comment.
Suggested change
| return common.Address{}, fmt.Errorf(`invalid creation code "%v": %w`, context.CreationCode, err) | |
| return common.Address{}, fmt.Errorf("invalid creation code %q: %w", context.CreationCode, err) |
VojtechVitek
reviewed
Aug 7, 2025
There was a problem hiding this comment.
@shunkakinoki @attente before I go through the PR in detail, what's the high-level update on this PR? Did we stabilize the v3 contracts? Is this backward-compatible regarding v1/v2?
(+38,535 added lines makes me a bit nervous :D)
It looks like we're already using this branch in relayer -- https://github.com/0xsequence/relayer/blob/master/go.mod#L29.
And we're ready to use it in stack/api too: https://github.com/0xsequence/stack/pull/1187.
That makes me think we're close?
Do we need any more time to refactor/polish this PR? Or is this ready to go?
Co-authored-by: Shun Kakinoki <[email protected]>
…721cdd882f92521a2742d07
lib/forge-std
Outdated
There was a problem hiding this comment.
Are we adding a new git module into the repository? Do we need to?
Can we embed/vendor/use forge some other way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all required core
configuration,imageHash,signaturemodules derived from sequence-core forv3and ensures that all critical tests are passing.Steps to test
rpc:Caveats
Some gas-estimation commands, etc. are commented out because of the scope of this PR. will follow up in a later PR. Also,
Permission,SmartSession,SessionManagerrelated modules will follow up later.