Add Optimistic Updates for Listings, Offers, and Collectibles + Refactor Footer/MarketCard #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g handling - Removed the useLowestListing hook from the Footer component, simplifying the data fetching logic. - Added lowestListing prop to the Footer component to allow for direct data passing. - Updated MarketCard component to retrieve lowestListing from collectible data and pass it to the Footer component. - Improved loading state logic in the Footer component for better performance and clarity.
- Introduced a new file `optimisticUpdates.ts` containing functions to optimistically update the list of collectibles in the cache when offers or listings are created. - Implemented `updateListCollectiblesWithOffer` and `updateListCollectiblesWithListing` functions to handle optimistic updates and rollback functionality. - Added utility functions to invalidate related offer and listing queries to ensure data consistency. - Exported the new functions from the `index.ts` utility file for accessibility throughout the SDK.
- Introduced `optimisticOffer.tsx` to manage optimistic updates for offers, allowing for immediate UI feedback while ensuring data consistency. - Implemented `getOptimisticOfferData` in `getOptimisticOfferData.ts` to generate optimistic offer objects based on user input and current state. - Updated `useTransactionSteps.tsx` to integrate optimistic updates, applying them after a successful transaction and rolling back if the transaction fails. - Removed the need for manual query invalidation by leveraging optimistic updates for a more efficient data handling approach.
- Introduced `optimisticListing.tsx` to handle optimistic updates for listings, allowing for immediate UI feedback while ensuring data consistency. - Added `getOptimisticListingData.ts` to generate optimistic listing objects based on user input and current state. - Updated `useTransactionSteps.tsx` to integrate optimistic updates, applying them after a successful transaction and rolling back if the transaction fails. - Modified `index.ts` in the hooks directory to export the new mutation hooks for better accessibility throughout the SDK.
mithatakbulut
requested review from
a team and
0xsequence-bot
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces optimistic updates across listings, offers, and collectibles to provide immediate UI feedback and improve overall performance, while also refactoring key components for simpler data handling.
Features
Listings (CreateListingModal):
Offers (MakeOfferModal):
Collectibles (React Query):
Refactors