Trails #541
Draft
Trails #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated BuyModalContent to utilize the new useMarketOrderData hook for fetching collectible and currency information when the selected chain is unsupported. - Improved loading state management by consolidating loading checks into a single variable. - Enhanced fallback UI to ensure all necessary data (collectible, order, currency, calldata) is available before rendering. Additionally, added the useMarketOrderData hook to manage market order data retrieval, including error handling and loading states.
- Introduced the `useOrders` hook to facilitate fetching orders from the marketplace with customizable parameters. - Created the `fetchOrders` function to interact with the marketplace API and retrieve order data. - Added `ordersQueryOptions` to manage query configurations for fetching orders. - Removed the obsolete `useCheckoutOptions` hook to streamline the codebase and improve maintainability. - Updated `useMarketOrderData` to utilize the new `useOrders` hook for fetching order data, enhancing the integration with the BuyModal. This commit enhances the order management capabilities within the application, providing a more efficient way to handle order data retrieval.
Simple buy modal -> Trails
…integration. Updated price display to use formattedPrice and replaced img tag with Media component for better asset handling.
…nAddress to the returned data from useBuyModalData. Updated import paths for useSupportedChains to align with the new package structure.
Fallback buy modal UI fix
…out opacity because it's used in background of dropdowns as well
remove opacity from --trails-bg-secondary and replace with matching color
|
|
||
| const isLoading = isLoadingSteps || isLoadingChains || isBuyModalDataLoading; | ||
|
|
||
| const buyStep = steps?.find((step) => step.id === 'buy'); |
There was a problem hiding this comment.
Optional:
StepType.buy instead of 'buy'
|
|
||
| const config = useConfig(); | ||
|
|
||
| const formattedAmount = currency?.decimals |
There was a problem hiding this comment.
Probably I should have done better check here. Instead of default amount to "0", I should have return an error saying currency.decimals couldn't find.
| queryFn: async () => { | ||
| if (!address || !publicClient) return; | ||
|
|
||
| const balance = nativeToken |
There was a problem hiding this comment.
We have useCurrencyBalance. You can pass zeroAddress from viem is it's native currency.
There was a problem hiding this comment.
But we need an async version?
… checks in the enabled condition, ensuring sufficient balance validation is more robust.
… data retrieval. Added support for shop properties and adjusted collectibleId logic to handle items array. Enhanced error handling by including collectionError in the isError state.
…d improving price display logic. Added FallbackPurchaseUISkeleton for loading indication, updated price calculations to handle market and sale scenarios, and refined balance checks to account for loading states.
Trails shop fallback UI
…nd integrating tooltips for better user experience. Introduced renderPriceUSD and renderCurrencyPrice functions to improve price display, ensuring accurate representation of free and low-value items.
…lay-enhancement Enhance FallbackPurchaseUI by adding currency price rendering logic a…
…I for transaction execution
…ransaction status modal state - Adjusted error handling in BuyModalContent to check for order existence based on market status.
…cution - Added useToast for user notifications. - Implemented validation for required parameters (data, to, value) in executeTransaction function. - Improved error messaging to provide detailed context when validation fails.
Fix - Fallback Purchase Modal -> Txn status modal display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.