feat: enhance FallbackPurchaseUI with WaaS fee options integration #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for WaaS fee options in the FallbackPurchaseUI component. - Integrated `useSelectWaasFeeOptions` and `selectWaasFeeOptionsStore` for managing fee visibility and selection. - Updated the buy button label dynamically based on the selected fee option. - Improved transaction handling by showing fee options when applicable, particularly for non-testnet environments. - Refactored conditional rendering for the buy button and fee options to enhance user experience.
mithatakbulut
requested review from
0xsequence-bot and
a team
as code owners
sdk/src/react/ui/modals/BuyModal/components/FallbackPurchaseUI.tsx
Outdated
Show resolved
Hide resolved
mithatakbulut
commented
Sep 18, 2025
…label handling - Removed unused imports related to network type checks. - Simplified the logic for determining button labels for approval and purchase actions. - Enhanced conditional rendering for action buttons based on transaction states and WaaS integration. - Improved user feedback by dynamically updating button labels during transaction processing.
sdk/src/react/ui/modals/BuyModal/components/FallbackPurchaseUI.tsx
Outdated
Show resolved
Hide resolved
sdk/src/react/ui/modals/BuyModal/components/FallbackPurchaseUI.tsx
Outdated
Show resolved
Hide resolved
…actNode elements
… state from `useWaasFeeOptions` of `sequence-connect` package
…. Refactor FallbackPurchaseUI accordingly
mithatakbulut
commented
Sep 18, 2025
| nuqs: ^2.6.0 | ||
| react: ^19.1.1 | ||
| react-day-picker: ^9.9.0 | ||
| 0xtrails: ^0.1.6 |
There was a problem hiding this comment.
I temporarily removed it to work in peace. I will take it back when PR is done.
|
It auto selects an available fee option. If WaaS account doesn't have balance to afford any of the fee options, it fails executing the transaction 👇🏼 (the log in console shows native balance and usdc balance in Polygon respectively) Screen.Recording.2025-09-19.at.12.23.56.mov |
- Modified the `onSuccessCallback` type to accept both `Hash` and `string` for the `hash` parameter. - Updated the `handleTransactionSuccess` function to handle the new hash type. - Adjusted type annotations in `BuyModalContent` to ensure compatibility with the updated hash handling. These changes enhance the flexibility of the BuyModal component in handling transaction success scenarios.
…lity with onSuccess callbacks - Updated the `onSuccess` handler in `useGenerateCancelTransaction`, `useGenerateListingTransaction`, and `useGenerateSellTransaction` to ensure that only the data (steps) is passed to the user's callback. - Removed unnecessary parameters from test cases in the corresponding test files to streamline assertions.
|
Tests of some of the transaction hooks (createListing, sell, cancel) were failing (https://github.com/0xsequence/marketplace-sdk/actions/runs/17854875009/job/50771510783) and I made changes to both their test files and |
sdk/src/react/ui/modals/BuyModal/components/FallbackPurchaseUI.tsx
Outdated
Show resolved
Hide resolved
sdk/src/react/ui/modals/BuyModal/components/useWaasFeeOptions.tsx
Outdated
Show resolved
Hide resolved
…chaseUI - Introduced a new `ErrorLogBox` component to display error messages with an option to view full error details. - Updated `FallbackPurchaseUI` to manage error states, replacing toast notifications with the `ErrorLogBox` for better user experience. - Implemented error handling for invalid steps and transaction failures, providing detailed error information to users. - Ensured that previous errors are cleared before new actions are executed, maintaining a clean error state.
sdk/src/react/ui/modals/BuyModal/components/BuyModalContent.tsx
Outdated
Show resolved
Hide resolved
.../ui/modals/_internal/components/selectWaasFeeOptions/__tests__/SelectWaasFeeOptions.test.tsx
Outdated
Show resolved
Hide resolved
sdk/src/react/ui/modals/BuyModal/components/FallbackPurchaseUI.tsx
Outdated
Show resolved
Hide resolved
…uteBuy` to execute a transaction or a bundled transactions whether it's shop or market
…approach with waasFeeOptionsStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useSelectWaasFeeOptionsandselectWaasFeeOptionsStorefor managing fee visibility and selection.Market Purchase (testnet + mainnet) - WAAS
mainnet.-.market.-waas.mov
testnet.-.market.-.waas.mov
Shop Purchase (testnet + mainnet) - WAAS
shop.-.waas.mov