Skip to content

feat: new diagnostic MissingSuppressionComment - #4400

Open
pravets wants to merge 1 commit into
1c-syntax:developfrom
pravets:feat/new-diagnostic-missing-suppression-comment
Open

feat: new diagnostic MissingSuppressionComment#4400
pravets wants to merge 1 commit into
1c-syntax:developfrom
pravets:feat/new-diagnostic-missing-suppression-comment

Conversation

@pravets

@pravets pravets commented Aug 3, 2026

Copy link
Copy Markdown

Closes #2779. Finds BSLLS suppression comments without explanation.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@pravets, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcb523b9-6a9c-43d7-8fb6-6cc733ccf480

📥 Commits

Reviewing files that changed from the base of the PR and between 0b45e3b and ef63fa3.

⛔ Files ignored due to path filters (1)
  • src/test/resources/diagnostics/MissingSuppressionCommentDiagnostic.bsl is excluded by !src/test/resources/**
📒 Files selected for processing (6)
  • docs/diagnostics/MissingSuppressionComment.md
  • docs/en/diagnostics/MissingSuppressionComment.md
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/MissingSuppressionCommentDiagnostic.java
  • src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/MissingSuppressionCommentDiagnostic_en.properties
  • src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/MissingSuppressionCommentDiagnostic_ru.properties
  • src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/MissingSuppressionCommentDiagnosticTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.


for (int i = 0; i < content.length; i++) {
var line = content[i].stripTrailing();
if (!line.stripLeading().startsWith("//")) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему висячие комментарии не проверяются?

public class MissingSuppressionCommentDiagnostic extends AbstractDiagnostic {

/** Строка начинается с {@code // BSLLS:...-off} или {@code // BSLLS-off}. */
private static final Pattern SUPPRESSION_PATTERN = Pattern.compile(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

возможно вместо повторного парсинга имеет смысл заглянуть в DiagnosticIgnoranceData


## Особенности

- Диагностика сама **не подавляема** через `// BSLLS:MissingSuppressionComment-off`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не увидел, где реализуется эта особенность

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Отсутствует комментарий к экранированию диагностики

2 participants