PHP: Well deprecate lizmapProject class #5918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
reviewed
Jul 8, 2025
| return $this->proj->checkAclByUser($login); | ||
| } | ||
| } | ||
| class lizmapProject extends Project {} |
There was a problem hiding this comment.
Same as in #5917, should we remove this code instead ?
Without a removing of the code in core LWC, the removing in other LWC modules will "likely" never happen because always postponed...
This code is deprecated since august 2020, so 5 years old.
Otherwise, we keep the code as it is with all "legacy" methods existing, but having a jLog deprecated warning on every call, so it will force modules to update "quickly" because of the noise in logging.
There was a problem hiding this comment.
There was a problem hiding this comment.
Here we can drop this class, because lizmap::getProject already returns \Lizmap\Project\Project
The lizmapProject class now extends \Lizmap\Project\Project.
rldhont
force-pushed
the
php-lizmapproject-deprecation
branch
from
d48fea8 to
95297a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lizmapProject class now extends \Lizmap\Project\Project.