Skip to content

fix: validate allowed frozen column & alert when invalid #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: validate allowed frozen column & alert when invalid #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0637485
fix: validate allowed frozen column & alert when invalid
ghiscoding Sep 22, 2025
0d95bcd
chore: small typo
ghiscoding Sep 23, 2025
b7c9fee
chore: small typo
ghiscoding Sep 23, 2025
0146417
chore: fix Cypress flaky test
ghiscoding Sep 23, 2025
3e45be7
chore: fix Cypress flaky test
ghiscoding Sep 23, 2025
c2c0564
fix: removing left column from picker w/only 1 col on right should be ok
ghiscoding Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cypress/e2e/example-auto-scroll-when-dragging.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,7 @@ describe('Example - Auto scroll when dragging', { retries: 1 }, () => {
.then(() => {
expect(stub.getCall(0)).to.be.calledWith(
'[SlickGrid] You are trying to freeze/pin more columns than the grid can support. ' +
'Make sure to have less columns pinned (on the left) than the actual visible grid width. ' +
'Also, please remember that only the columns on the right are scrollable and the pinned columns are not.'
'Make sure to have less columns pinned (on the left) than the actual visible grid width.'
);

// it should still have previous pinning
Expand Down
Loading