fix: column header reorder should keep scroll position even frozen grid #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases when we have a grid with a
frozenColumn(pinning) defined and then on the right section, we scroll a bit on the right and then if we changed the column header reorder it could sometime cause a bug that the column header titles didn't align with the data (the titles was scrolled back toscrollLeft: 0while the data itself stayed at the same scroll position causing the misalignment). So to avoid such issues, we can simply scroll to the same X coordinate which we had before executing the action (I moved some internal code into a now public function namedscrollToX()that we now call after the header title reordering is finished.