Skip to content

Create TDD example #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 56 additions & 2 deletions src/main/java/com/hangman/players/YourPlayer.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,65 @@

import com.hangman.Player;

import java.util.List;
import java.util.*;

public class YourPlayer implements Player {
private Stack<Character> priorityStack = new Stack();
private Stack<Character> secondaryStack = new Stack();

private List<Character> priorityCharacters = new ArrayList();
private List<Character> secondaryCharacters = new ArrayList();

private boolean emptyCurrentClueList = true;

public YourPlayer(){
priorityCharacters = Arrays.asList('u', 'l', 'd', 'r', 'h', 's', 'n', 'i', 'o', 'a', 't', 'e');

secondaryCharacters = Arrays.asList('b', 'c', 'd', 'f', 'g', 'j', 'k', 'm', 'p', 'q', 'v', 'w', 'x', 'y', 'z');

for (Character letter : priorityCharacters){
priorityStack.push(letter);
}

for (Character letter : secondaryCharacters){
secondaryStack.push(letter);
}
}

@Override
public char getGuess(List<Character> currentClue) {
return 'a';
checkIfEmptyCurrentClueList(currentClue);

if (emptyCurrentClueList){
return priorityStack.pop();
}
else {
return getNextGuess();
}
}

private void checkIfEmptyCurrentClueList(List<Character> currentClue){
for (Character element : currentClue)
if (element != null){
emptyCurrentClueList = false;
}
}
private char getNextGuess(){
if (priorityStack.isEmpty()){
return getGuessFromSecondaryStack();
}
else {
return priorityStack.pop();
}
}

private char getGuessFromSecondaryStack(){
if (secondaryStack.isEmpty()){
// No more guesses left ... ???
return 'A';
}
else {
return secondaryStack.pop();
}
}
}
21 changes: 11 additions & 10 deletions src/test/java/com/hangman/players/YourPlayerTest.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
package com.hangman.players;

import org.junit.Test;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;

public class YourPlayerTest {
@Test
Expand All @@ -11,24 +16,20 @@ public void guessesAWhenThereAreNoSuccessfulCharactersGuessedYet() {

char guess = player.getGuess(Arrays.asList(null, null, null));

assertEquals('a', guess);
assertEquals('e', guess);
}

@Test
public void guessesAWhenThereAreSuccessfulCharactersGuessedThatAreNotA() {
public void guessesLetterNotInCurrentClueList() {
YourPlayer player = new YourPlayer();

char guess = player.getGuess(Arrays.asList('m', null, 'n'));

assertEquals('a', guess);
boolean guessNotInList = assertGuessNotInList(guess, Arrays.asList('m', null, 'n'));
assertEquals(true, guessNotInList);
}

@Test
public void guessesAWhenAIsThereAreAsInTheClueAsWell() {
YourPlayer player = new YourPlayer();

char guess = player.getGuess(Arrays.asList(null, 'a', null));

assertEquals('a', guess);
static boolean assertGuessNotInList(char guess, List<Character> currentClueList) {
return (!(currentClueList.contains(guess)));
}
}