Skip to content

Conversation

Skeeg
Copy link
Contributor

@Skeeg Skeeg commented Feb 28, 2025

No description provided.

@Skeeg Skeeg marked this pull request as draft February 28, 2025 01:01
Copy link
Collaborator

@timkinnane timkinnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @Skeeg, thanks for contributing.

I made a similar change locally just a couple days ago after finding that sourcing asdf.sh hasn't been required for quite a while.

I left the environment file loading though because I had to add some other values to get plugins working, e.g:

export ASDF_DIR="$HOME/.asdf"
export ASDF_DATA_DIR="$HOME/.asdf"
export PATH="${ASDF_DATA_DIR:-$HOME/.asdf}/shims:$PATH"
export ASDF_CONCURRENCY=auto

I'm not sure any of that is actually necessary though, or just a problem with the Node plugin version.

I'd be okay with your changes as is for now if you take them out of draft, then we can see about moving to Mise as a follow up. It does seem a lot easier to setup and maintain so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants