Migrate DotProductAttention to NNX #2198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandermoon
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Thank you @hsuan-lun-chiang. Could you check why the GPU integration test is failing?
Comment on lines
+551
to
+563
| dummy_query_prefill = jnp.zeros((1, self.max_target_length, self.num_query_heads, config.head_dim), dtype=self.dtype) | ||
| dummy_key_prefill = jnp.zeros((1, self.max_target_length, self.num_kv_heads, config.head_dim), dtype=self.dtype) | ||
| dummy_value_prefill = jnp.zeros((1, self.max_target_length, self.num_kv_heads, config.head_dim), dtype=self.dtype) |
There was a problem hiding this comment.
@cgarciae are zeros the right value here?
hsuan-lun-chiang
force-pushed
the
feat/Migrate-DotProductAttention-to-NNX
branch
from
bd06740 to
16ad76e
Compare
Sure! It was causes by None being casting to uint8, fixed it. Thank you. |
hsuan-lun-chiang
requested review from
gobbleturk,
khatwanimohit,
vipannalla,
RissyRan,
richjames0,
gagika,
shralex,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha,
aireenmei and
NuojCheng
as code owners
bvandermoon
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
LGTM. Thank you @hsuan-lun-chiang. Did you run the description test on a GPU VM? Let's get @cgarciae's thoughts as well
Happy to help! Yes, I ran the test on a GPU VM with A100 80GB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate DotProductAttention to NNX.
Tests
Train Gemma-2b with attention=cudnn_flash_te, which use DotProductAttention:
Logs - After Migration
Logs - Before Migration
Checklist
Before submitting this PR, please make sure (put X in square brackets):