Support multimodal in logit checker + match gemma3 logits with HF #2203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found some mismatch in gemma3 logits compared with HF (b/437988753).
Key changes to fill the gap:
Tests
Use generate_hf_golden_logits.py to generate HF logits on a m1 CPU, dtype=float32
Run forward_pass_logit_checker on a v5p TPU, with all the dype and precision set to float32
Results: see b/437988753
Checklist
Before submitting this PR, please make sure (put X in square brackets):