Skip to content

Conversation

RissyRan
Copy link
Collaborator

Description

To fix #2207:

  • Remove checkpoint_dots_with_no_batch_dims with specific rules
  • Update minimal_flash rule to minimal_with_context to align current naming
  • Test changes accordingly

Tests

Expect compile/unit tests pass.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@khatwanimohit khatwanimohit removed their assignment Aug 25, 2025
Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ran!

@copybara-service copybara-service bot merged commit 83097dd into main Aug 29, 2025
18 checks passed
@copybara-service copybara-service bot deleted the remat_fix branch August 29, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remat Policy minimal does not work for MoE models
4 participants