Skip to content

Add a flag to enable cloud DNS when creating cluster #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add a flag to enable cloud DNS when creating cluster #580

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ccea48
Add a flag to support cloud DNS
dannikay Aug 7, 2025
ec5f9ed
fix flag name
dannikay Aug 7, 2025
8804fc2
skip core DNS when cloud dns is enabled
dannikay Aug 7, 2025
6a62a34
reuse custom cluster arguments isnteead
dannikay Aug 7, 2025
824f6b1
Update CODEOWNERS
dannikay Aug 7, 2025
703cba5
Merge branch 'AI-Hypercomputer:develop' into clouddnsflag
dannikay Aug 10, 2025
97869f8
Merge branch 'AI-Hypercomputer:develop' into clouddnsflag
dannikay Aug 12, 2025
b1bc6d3
Merge branch 'develop' into clouddnsflag
dannikay Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/xpk/commands/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,10 @@ def update_coredns_if_necessary(args) -> int:
0 if successful (CoreDNS was already present or successfully deployed),
and 1 otherwise.
"""
if coredns_deployment_exists(args, namespace='kube-system'):
if '--cluster-dns=clouddns' in args.custom_cluster_arguments:
xpk_print('Skipping CoreDNS deployment since Cloud DNS is enabled.')
return 0
elif coredns_deployment_exists(args, namespace='kube-system'):
xpk_print('Skipping CoreDNS deployment since it already exists.')
return 0
else:
Expand Down