Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jun 30, 2025

Remove bool->float substitution. This is (or should be) handled somewhere else.

Related to #2840.

@dweindl dweindl self-assigned this Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.70%. Comparing base (08bf630) to head (b2477ea).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   80.38%   79.70%   -0.69%     
==========================================
  Files         329      329              
  Lines       22410    22410              
  Branches     1514     1514              
==========================================
- Hits        18014    17861     -153     
- Misses       4385     4538     +153     
  Partials       11       11              
Flag Coverage Δ
cpp 75.42% <100.00%> (-0.10%) ⬇️
cpp_python 33.84% <100.00%> (ø)
petab 39.25% <100.00%> (ø)
python 74.45% <100.00%> (-0.10%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 82.07% <100.00%> (-12.13%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl changed the title SBML import: Boolean handling SBML import: Remove some bool->float conversion Jun 30, 2025
@dweindl dweindl marked this pull request as ready for review June 30, 2025 08:27
@dweindl dweindl requested a review from a team as a code owner June 30, 2025 08:27
@dweindl dweindl enabled auto-merge June 30, 2025 08:27
@dweindl dweindl added this pull request to the merge queue Jun 30, 2025
Merged via the queue into AMICI-dev:main with commit ac676ef Jun 30, 2025
31 of 32 checks passed
@dweindl dweindl deleted the sbml_bool branch June 30, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants