Skip to content

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 20, 2025

Make relevant ReturnData fields available as xarray.DataArray. This includes the identifiers and is often more convenient than the plain arrays, allows for easy subselection and plotting of the results, and conversion to DataFrames.

Closes #2170.

@dweindl dweindl self-assigned this Jul 20, 2025
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

❌ Patch coverage is 35.89744% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.53%. Comparing base (8b832ca) to head (af0d3f7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/numpy.py 35.89% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2916      +/-   ##
==========================================
- Coverage   77.24%   76.53%   -0.71%     
==========================================
  Files         307      307              
  Lines       19912    19951      +39     
  Branches     1502     1502              
==========================================
- Hits        15381    15270     -111     
- Misses       4518     4668     +150     
  Partials       13       13              
Flag Coverage Δ
cpp 72.70% <35.89%> (-0.03%) ⬇️
cpp_python 38.25% <15.38%> (-0.05%) ⬇️
petab 39.30% <15.38%> (-0.06%) ⬇️
python 70.26% <35.89%> (-0.02%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/numpy.py 74.67% <35.89%> (-13.16%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

socket-security bot commented Oct 2, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedxarray@​2025.9.193100100100100

View full report

@dweindl dweindl marked this pull request as ready for review October 6, 2025 09:11
@dweindl dweindl requested a review from a team as a code owner October 6, 2025 09:11
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Make relevant `ReturnData` fields available as `xarray.DataArray`.
This includes the identifiers and is often more convenient than the plain arrays, allows for easy subselection and plotting of the results, and conversion to DataFrames.
@dweindl dweindl merged commit d5d77c4 into AMICI-dev:main Oct 6, 2025
16 of 18 checks passed
@dweindl dweindl deleted the feature_xarray branch October 6, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ReturnDataView attributes to xarray.DataArray?

2 participants