Skip to content

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 3, 2025

Combine observables, sigmas and noise distributions parameters for model import

Closes #2923.

@dweindl dweindl self-assigned this Oct 3, 2025
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.67%. Comparing base (d5492c3) to head (16df5e4).

Files with missing lines Patch % Lines
python/sdist/amici/de_model.py 83.33% 2 Missing ⚠️
python/sdist/amici/sbml_import.py 94.11% 2 Missing ⚠️
python/sdist/amici/import_utils.py 93.75% 1 Missing ⚠️
python/sdist/amici/petab/import_helpers.py 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2959      +/-   ##
==========================================
- Coverage   77.29%   76.67%   -0.62%     
==========================================
  Files         307      307              
  Lines       19912    19901      -11     
  Branches     1502     1502              
==========================================
- Hits        15391    15260     -131     
- Misses       4508     4628     +120     
  Partials       13       13              
Flag Coverage Δ
cpp 72.84% <90.58%> (+0.06%) ⬆️
cpp_python 38.33% <76.47%> (+0.02%) ⬆️
petab 39.39% <69.41%> (+0.03%) ⬆️
python 70.39% <92.94%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 96.07% <ø> (ø)
python/sdist/amici/petab/pysb_import.py 61.76% <ø> (ø)
python/sdist/amici/petab/sbml_import.py 74.60% <100.00%> (+0.20%) ⬆️
python/sdist/amici/pysb_import.py 94.76% <100.00%> (+0.19%) ⬆️
python/sdist/amici/testing/models.py 98.36% <ø> (ø)
python/tests/conftest.py 39.28% <ø> (ø)
python/sdist/amici/import_utils.py 81.64% <93.75%> (-2.13%) ⬇️
python/sdist/amici/petab/import_helpers.py 85.71% <91.66%> (-1.25%) ⬇️
python/sdist/amici/de_model.py 92.33% <83.33%> (-0.60%) ⬇️
python/sdist/amici/sbml_import.py 81.40% <94.11%> (-10.97%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the gh-2923-obs-model branch from 87c6558 to e54c2f4 Compare October 3, 2025 15:18
@dweindl dweindl force-pushed the gh-2923-obs-model branch from 9076be5 to db1c444 Compare October 4, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine observables, sigmas and noise distributions parameters for model import
1 participant