fix(qemu): Wrap topology declaration in braces to allow local variable declaration #2018
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e declaration
- `struct platform_cpu_topology topology` must be inside a block; otherwise Clang
will error out.
```
INFO - CC plat/qemu/qemu_sbsa/sbsa_sip_svc.c
INFO - plat/qemu/qemu_sbsa/sbsa_sip_svc.c:86:3: error: label followed by a
declaration is a C23 extension [-Werror,-Wc23-extensions]
INFO - 86 | struct platform_cpu_topology topology;
INFO - | ^
INFO - 1 error generated.
```
Signed-off-by: Vineel Kovvuri[MSFT] <[email protected]>
|
Hello @vineelko! Thank you for your contribution to Trusted Firmware-A! The TF-A project is hosted on https://www.trustedfirmware.org and https://git.trustedfirmware.org/plugins/gitiles/TF-A/trusted-firmware-a/ This github mirror still exists for historical reasons and should no longer be used. From now please use the active read-only mirror Contributions shall be posted to https://review.trustedfirmware.org/ according to the guide The TF-A mailing list shall be used for design discussions. We are looking forward to seeing you in trustedfirmware.org! The Trusted Firmware-A team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct platform_cpu_topology topologymust be inside a block; otherwise Clang will error out.