#186 Add string encoders #770
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright 2018 ABSA Group Limited | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package za.co.absa.cobrix.cobol.parser.encoders | ||
|
|
||
| object StringEncoders { | ||
| /** | ||
| * An encoder from a string to an EBCDIC byte array | ||
| * | ||
| * @param string An input string | ||
| * @param conversionTable A conversion table to use to convert from ASCII to EBCDIC | ||
| * @param length The length of the output (in bytes) | ||
| * @return A string representation of the binary data | ||
| */ | ||
| def encodeEbcdicString(string: String, conversionTable: Array[Byte], length: Int): Array[Byte] = { | ||
| require(length >= 0, s"Field length cannot be negative, got $length") | ||
|
|
||
| var i = 0 | ||
| val buf = new Array[Byte](length) | ||
|
|
||
| while (i < string.length && i < length) { | ||
| val asciiByte = string(i).toByte | ||
| buf(i) = conversionTable((asciiByte + 256) % 256) | ||
| i = i + 1 | ||
| } | ||
| buf | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package za.co.absa.cobrix.cobol.parser.encoders | ||
|
|
||
| import org.scalatest.WordSpec | ||
| import za.co.absa.cobrix.cobol.parser.decoders.StringDecoders | ||
| import za.co.absa.cobrix.cobol.parser.decoders.StringDecoders.TrimNone | ||
| import za.co.absa.cobrix.cobol.parser.encoding.codepage.CodePageCommon | ||
|
|
||
| class StringEncodersSpec extends WordSpec { | ||
| "encodeEbcdicString" should { | ||
| "be able to covert a basic ASCII string to EBCDIC" in { | ||
| val input = "0123456789 abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ+-=<>[](){},./;:?!|$*~^`#@%_\\\'\"\r\n" | ||
|
|
||
| val codePage = new CodePageCommon | ||
|
|
||
| val ebcdic = StringEncoders.encodeEbcdicString(input, codePage.getAsciiToEbcdicMapping, input.length) | ||
| val ascii = StringDecoders.decodeEbcdicString(ebcdic, TrimNone, codePage.getEbcdicToAsciiMapping) | ||
|
|
||
| assert(ascii == input) | ||
| } | ||
|
|
||
| "be able to covert shorter strings" in { | ||
| val input = "0123456789" | ||
| val expected = "01234" | ||
|
|
||
| val codePage = new CodePageCommon | ||
|
|
||
| val ebcdic = StringEncoders.encodeEbcdicString(input, codePage.getAsciiToEbcdicMapping, 5) | ||
| val ascii = StringDecoders.decodeEbcdicString(ebcdic, TrimNone, codePage.getEbcdicToAsciiMapping) | ||
|
|
||
| assert(ebcdic.length == 5) | ||
| assert(ascii == expected) | ||
| } | ||
|
|
||
| "be able to covert longer strings" in { | ||
| val input = "012" | ||
| val expected = "F0F1F20000" | ||
|
|
||
| val codePage = new CodePageCommon | ||
|
|
||
| val ebcdic = StringEncoders.encodeEbcdicString(input, codePage.getAsciiToEbcdicMapping, 5) | ||
| val ebcdicHex = StringDecoders.decodeHex(ebcdic) | ||
|
|
||
| assert(ebcdic.length == 5) | ||
| assert(expected == ebcdicHex) | ||
| } | ||
|
|
||
| "be able to covert an empty string" in { | ||
| val codePage = new CodePageCommon | ||
|
|
||
| val ebcdic = StringEncoders.encodeEbcdicString("", codePage.getAsciiToEbcdicMapping, 0) | ||
|
|
||
| assert(ebcdic.length == 0) | ||
| } | ||
|
|
||
| "throws an exception if a negative value was passed" in { | ||
| val codePage = new CodePageCommon | ||
|
|
||
| val ex = intercept[IllegalArgumentException] { | ||
| StringEncoders.encodeEbcdicString("123", codePage.getAsciiToEbcdicMapping, -1) | ||
| } | ||
|
|
||
| assert(ex.getMessage.contains("requirement failed: Field length cannot be negative, got -1")) | ||
| } | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the method name to match its purpose.
The method name
asciiToAsciiMappingis incorrect. Based on the documentation comment and usage context, this should beasciiToEbcdicMappingsince it provides ASCII-to-EBCDIC conversion.📝 Committable suggestion
🤖 Prompt for AI Agents